Skip to content

gha: SEV deprecation #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arvindskumar99 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gha: SEV deprecation #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion attestation-service/docs/grpc-as.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

Now the following types of evidence are supported:
- `az-snp-vtpm`: Azure SNP vTPM
- `sev`: AMD SEV (Not implemented)
- `sgx`: Intel SGX
- `snp`: AMD SNP
- `tdx`: Intel TDX
Expand Down
1 change: 0 additions & 1 deletion attestation-service/src/bin/grpc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ use crate::rvps_api::{

fn to_kbs_tee(tee: &str) -> anyhow::Result<Tee> {
let tee = match tee {
"sev" => Tee::Sev,
"sgx" => Tee::Sgx,
"snp" => Tee::Snp,
"tdx" => Tee::Tdx,
Expand Down
1 change: 0 additions & 1 deletion attestation-service/src/bin/restful/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ enum InitDataInput {
fn to_tee(tee: &str) -> anyhow::Result<Tee> {
let res = match tee {
"az-snp-vtpm" => Tee::AzSnpVtpm,
"sev" => Tee::Sev,
"sgx" => Tee::Sgx,
"snp" => Tee::Snp,
"tdx" => Tee::Tdx,
Expand Down
1 change: 0 additions & 1 deletion deps/verifier/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@

pub fn to_verifier(tee: &Tee) -> Result<Box<dyn Verifier + Send + Sync>> {
match tee {
Tee::Sev => todo!(),
Copy link
Member

@Xynnn007 Xynnn007 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust will require all possibilities to be exhausted when matching enum, and sev is defined in kbs-types, so there will be a compilation error here. We need to delete this enum from the upstream, here

Copy link
Author

@arvindskumar99 arvindskumar99 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xynnn007 I've opened a PR in kbs-types with this change: confidential-containers/kbs-types#78

Copy link
Member

@Xynnn007 Xynnn007 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confidential-containers/kbs-types#78 has been merged.

Copy link
Contributor

@mythi mythi Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arvindskumar99 please update

Copy link
Author

@arvindskumar99 arvindskumar99 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xynnn007 if everything else looks good, can you go ahead and approve the PR? Need one more green check before it can get merged.

Copy link
Member

@Xynnn007 Xynnn007 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still CI errors. Please fix them and force push. Also you need to update the kbs-types version the the latest which does not include sev enum

Tee::AzSnpVtpm => {
cfg_if::cfg_if! {
if #[cfg(feature = "az-snp-vtpm-verifier")] {
Expand All @@ -63,7 +62,7 @@
if #[cfg(feature = "az-tdx-vtpm-verifier")] {
Ok(Box::<az_tdx_vtpm::AzTdxVtpm>::default() as Box<dyn Verifier + Send + Sync>)
} else {
bail!("feature `az-tdx-vtpm-verifier` is not enabled for `verifier` crate.");

Check failure on line 65 in deps/verifier/src/lib.rs

View workflow job for this annotation

GitHub Actions / Check (ubuntu-24.04-arm, coco-as-builtin,coco-as-grpc,intel-trust-authority-as,sample_only,cca-at... 

non-exhaustive patterns: `&Tee::Sev` not covered

Check failure on line 65 in deps/verifier/src/lib.rs

View workflow job for this annotation

GitHub Actions / Check (ubuntu-24.04) 

non-exhaustive patterns: `&Tee::Sev` not covered

Check failure on line 65 in deps/verifier/src/lib.rs

View workflow job for this annotation

GitHub Actions / Check (ubuntu-24.04) 

non-exhaustive patterns: `&Tee::Sev` not covered

Check failure on line 65 in deps/verifier/src/lib.rs

View workflow job for this annotation

GitHub Actions / Check (ubuntu-24.04-arm) 

non-exhaustive patterns: `&Tee::Sev` not covered

Check failure on line 65 in deps/verifier/src/lib.rs

View workflow job for this annotation

GitHub Actions / Check 

non-exhaustive patterns: `&Tee::Sev` not covered

Check failure on line 65 in deps/verifier/src/lib.rs

View workflow job for this annotation

GitHub Actions / TEE=snp Generate Evidence Dynamically=false 

non-exhaustive patterns: `&Tee::Sev` not covered
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion kbs/docs/kbs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ components:
type: string
tee:
type: string
enum: [amd-sev, intel-sgx, intel-tdx]
enum: [amd-sev-snp, intel-sgx, intel-tdx]
extra-params:
description: >-
Freely formatted JSON object used for HW-TEE specific attestation
Expand Down
3 changes: 1 addition & 2 deletions kbs/docs/kbs_attestation_protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ The payload format of the request is as follows:
"version": "0.1.1",
/*
* Type of HW-TEE platforms where KBC is located,
* e.g. "tdx", "sev", "snp", etc.
* e.g. "tdx" or "snp", etc.
*/
"tee": "$tee",
/* Reserved fields to support some special requests sent by HW-TEE. */
Expand All @@ -97,7 +97,6 @@ Used to declare the type of HW-TEE platform where KBC is located. Currently, kno
|----------------|-------------------------------------------------------------------|
| `az-snp-vtpm` | Microsoft Azure AMD SNP VTPM |
| `az-tdx-vtpm` | Microsoft Azure TDX VTPM |
| `sev` | AMD SEV |
| `snp` | AMD SNP |
| `sgx` | Intel SGX |
| `tdx` | Intel TDX |
Expand Down
Loading