chore(deps): Bump bincode from 2.0.1 to 3.0.0 - #1247
Conversation
Bumps [bincode](https://github.com/bincode-org/bincode) from 2.0.1 to 3.0.0. - [Commits](https://github.com/bincode-org/bincode/commits) --- updated-dependencies: - dependency-name: bincode dependency-version: 3.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
fitzthum
left a comment
fitzthum
left a comment
There was a problem hiding this comment.
There is some weird drama going on with bincode. Do not merge this.
wow. looks like our dependencies to it are not too deep (and only isolated to sev kbc stuff?). might be better to just rework sev kbc to drop bincode or remove it alltogether (is this for simple-kbs?). |
|
@dependabot ignore this major version |
|
OK, I won't notify you about version 3.x.x again, unless you re-open this PR. |
|
@copilot create a new issue that lists options on how to move away from the unmaintained bincode crate in this repository. we have new forks available, such as https://crates.io/crates/bincode-next. we can move to use a fork, rework existing code to not use bincode to drop the dependency or remove online_sev_kbc completely. what else is using bincode in this repository |
|
does not seem to work it seems :-) |
So let the human-being AI to help ; P |
|
Oh. looks like now bincode is only used in online-sev-kbc. I am not sure if it is still used? cc @fitzthum |
That's basically the same question I had. The README suggests that is SEV specific and SNP is covered by Trustee so it sounds like this could be dropped completely. |
|
Yeah I think we can drop that SEV stuff. |
3 participants
Bumps bincode from 2.0.1 to 3.0.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)