e2e-test: improve ibmcloud tests #2761
Open
+37
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CONTAINER_RUNTIME to E2E properties. This allows defining crio as the runtime instead of containerd, which is used on ROKS. Signed-off-by: Patrik Fodor <[email protected]>
Introduced new instance profiles for E2E tests that support confidential computing on x86_64 machines. These profiles have different CPU and memory configurations, so memory and CPU annotations in several test cases were updated accordingly. Signed-off-by: Patrik Fodor <[email protected]>
stevenhorsman
approved these changes
Jan 6, 2026
Member
stevenhorsman
left a comment
stevenhorsman
left a comment
There was a problem hiding this comment.
The test changes look reasonable to me. It would be good to see the output of a manual run done in the PR comments as we have no automation that covers this
Update test assertions for: - DoTestPodVMwithAnnotationsInvalidInstanceType - DoTestPodVMwithAnnotationsLargerMemory - DoTestPodVMwithAnnotationsLargerCPU In these cases, PeerPods do not transition to the Failed state but remain in the Pending state. Although the expected event occurs, the tests were failing due to incorrect state checks. Signed-off-by: Patrik Fodor <[email protected]>
Pacho20
force-pushed
the
fix-ibmcloud-e2e
branch
from
bb568ab to
f4c7632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements to E2E tests and configuration related to IBM Cloud.
Enables defining crio as the container runtime instead of containerd (crio is the default on ROKS).
Introduces profiles supporting confidential computing on x86_64 machines.
Updated memory and CPU annotations in several test cases to match the increased resources of these profiles.
Adjusted assertions in tests where PeerPods remain in Pending instead of transitioning to Failed.
Although the expected event occurs, the tests were failing due to incorrect state checks.
I only ran these tests on IBM Cloud and never observed a PeerPod going into Failed state, so I assume Pending is the expected behavior. Let me know whether it's a bug or normal behavior.