fix(devcontainer): enforce linux/amd64 platform for Apple Silicon compatibility #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patibility - Replace image property with build using Dockerfile - Add Dockerfile with explicit --platform=linux/amd64 flag - Add runArgs and remoteEnv to enforce platform consistently - Fixes devcontainer build failures on Apple Silicon Macs Signed-off-by: OP <[email protected]>
mateo-moon
force-pushed
the
fix/devcontainer-platform-enforcement
branch
from
b9047d3 to
fe5d548
Compare
Contributor
Author
|
I didn't properly check backwards compatibility on linux machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes devcontainer build failures on Apple Silicon Macs by enforcing the
linux/amd64platform.Changes
imageproperty withbuildusing Dockerfile approach--platform=linux/amd64flagrunArgsandremoteEnvto enforce platform consistentlyProblem
On Apple Silicon Macs, VSCode devcontainers were building arm64 versions by default, causing:
Solution
By explicitly specifying
--platform=linux/amd64in the Dockerfile and devcontainer configuration, the container will always build for amd64 architecture, ensuring consistent behavior across different host platforms.Testing
Backward Compatibility
The Dockerfile approach maintains backward compatibility as it builds the same base image (
mcr.microsoft.com/devcontainers/base:ubuntu), just with explicit platform enforcement. On Linux/amd64 systems, this adds no performance overhead.