podvm-mkosi: Use Ubuntu 24.04 as the base #2663
Conversation
|
The entire code was primarily generated by AI, I made some minor changes and ran a successful build. Keeping this in draft for now as I want to run actual pod creation tests. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bpradipt
force-pushed
the
ubuntu-podvm-mkosi
branch
2 times, most recently
from
1c7d2d1 to
be8061a
Compare
|
This is ready for review. |
|
It's very difficult (for me at least) to be sure that all the mkosi presets/conf files are correct, but overall this looks good to my eyes. Have you tried building the normal and debug images with the workflow in your fork? If so could you link to the runs for reference. Thanks! |
src/cloud-api-adaptor/podvm-mkosi/mkosi.presets/system/mkosi.conf.d/ubuntu-sftp.conf
Show resolved
Hide resolved
ldoktor
left a comment
ldoktor
left a comment
There was a problem hiding this comment.
It looks fine although I'm wondering whether it's not a time to start generating the files out of a skeleton. The differences between fedora/ubuntu among different environments is minimal. On the other hand this is easier to modify ad-hoc, but any systematic change will become troublesome. I'd personally prefer a script that would map different pieces (like dnf/apt, pkg names, architecture) and the product would be just a single tree, what do you think?
As for functional testing, I only tried the smoke-test locally, image and debug-image worked well but sftp one kept rebooting (I had authorized_keys present and TLS_OPTIONS=-disable-tls).
That would be a good plan, but I think that the plan is to deprecate and remove the fedora based image due to lack of gpu support once we are comfortable with ubuntu, so I think that's why Pradipta has done more a a copy paste job to make the removal of the old version easier. |
|
@bpradipt - do you mind if I do the rebase and fix the zizmor warnings on this PR and push it back to your branch? |
stevenhorsman
force-pushed
the
ubuntu-podvm-mkosi
branch
from
be8061a to
1b0eafb
Compare
I decided to take the liberty of force pushing a bunch of fixes here as it seems like work had stalled on it. I've also tested the podvm workflow in https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/20434943704 which I got passing after some fixes, so I think this is ready to be merged. Thanks |
|
@stevenhorsman my apologies for the delay. Restarting this work again |
Use Ubuntu 24.04 LTS as the base podvm mkosi image Signed-off-by: Pradipta Banerjee <[email protected]> Assisted-by: AI Signed-off-by: stevenhorsman <[email protected]>
github actions for ubuntu based mkosi builds Signed-off-by: Pradipta Banerjee <[email protected]> Signed-off-by: stevenhorsman <[email protected]>
bpradipt
force-pushed
the
ubuntu-podvm-mkosi
branch
from
1b0eafb to
2d71757
Compare
|
@stevenhorsman do the e2e tests use mkosi based image? |
Yes - we have a separate set of e2e tests for the mkosi images. In my fork testing I just checked that the ubuntu podvm image builds were successful and figured we could merge that and then have a follow up to try and integrate e2e testing if that sounds okay? |
Sounds good |
mkulke
left a comment
mkulke
left a comment
There was a problem hiding this comment.
is there duplication in the new workflows? (can we generalize the existing workflows to support ubuntu)
there is no mention of afterburn. so this image wouldn't work on azure, due to the missing phone-home feature ("i'm ready"). Not sure this package is available in ubuntu, but since it's rust, we can maybe ship a binar, or alternatively add a bit of phone-home go code to this repo.
There is a lot of duplication. I was working on the assumption that we were spinning this up as a copy and once we've tested it we'd remove the fedora version and therefore the duplication, but your approach is also valid |
Right, the intention is to remove fedora once ubuntu is properly tested |
understood, that makes sense 👍 |
4 participants
Use Ubuntu 24.04 LTS as the base podvm mkosi image