test/e2e: fix undefined types.ContainerListOptions error in docker_common.go #2557
Conversation
|
The compilation error is gone but tests are failing (https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/17559490976/job/49872816638?pr=2557). I will have a look later. |
|
Sorry - my brain clearly wasn't working when I didn't run the docker tests for a docker change 😢 |
Does it need f1d7d99? |
yeah, probably. I just realized @bpradipt was already fixing the docker tests issues. I'm gonna close this one. |
|
Addressed in #2540 |
The error was introduced by commit a244398 which updated Docker Go SDK from v25.0.6 to v28.3.3 to remediate CVE-2025-54410. In Docker Go SDK v28, types.ContainerListOptions was moved from github.com/docker/docker/api/types to github.com/docker/docker/api/types/container and renamed to container.ListOptions. Assisted-by: Cursor Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Remove the `continue-on-error: true` setting from the docker e2e workflow now that the Docker Go SDK v28 compatibility issues have been fixed. The continue-on-error setting was masking test failures for ~3 weeks after the Docker Go SDK was updated to v28.3.3 in commit a244398. With the docker_common.go fix in place, the tests should now pass and any future failures will be properly reported. Assisted-by: Cursor Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Ensure configured API version is used for the provider and the related tests Signed-off-by: Pradipta Banerjee <[email protected]>
wainersm
force-pushed
the
fix_test_docker_common
branch
from
fe8e97f to
60b561a
Compare
stevenhorsman
merged commit b14ab10
into
confidential-containers:main
3 participants
The error was introduced by commit a244398 which updated Docker Go SDK from v25.0.6 to v28.3.3 to remediate CVE-2025-54410. In Docker Go SDK v28, types.ContainerListOptions was moved from github.com/docker/docker/api/types to github.com/docker/docker/api/types/container
and renamed to container.ListOptions.
Assisted-by: Cursor
The nightly e2e tests for docker as failed due that problem since https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/17117056929 . We never noticed because the workflow has
continue-on-errorenabled. It's continue-on-error since when the workflow was introduced last week, at that time I wanted to have it stable before fully enabling. Ok, I looked at the 5 jobs before that fail and all passed, so maybe we can consider the workflow stable and remove the continue-on-error flag?A: I added commit ea497e8 to remove the
continue-on-errorCherry-picked 60b561a from #2540