fix: Prevent noarch installer from installing non-noarch packages #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamthebot
changed the title
|
So, the windows x86_64 tests are failing due to "libsolv bindings not up to date". Any ideas on that @baszalmstra ? Windows aarch64 is fine. |
|
You changed the |
baszalmstra
requested changes
Oct 14, 2025
iamthebot
force-pushed
the
al--install_behavior_tweak
branch
from
851cf91 to
50fd57b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1712
If an installer platform is
noarchthen non-noarch packages should cause it to fail early. Not doing this leads to bad binaries and on OSX no codesigning. See the original issue for more details.AI Disclosure
Used sonnet 4.5 1M w/ codecompanion.nvim to bootstrap the unit tests.