-
Notifications
You must be signed in to change notification settings - Fork 101
feat: perf: skip shell if no activation scripts or conda prefix (#1696) #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: perf: skip shell if no activation scripts or conda prefix (#1696) #1700
Conversation
I think the idea is solid but I would like to double check whether this takes into account the environment variables from |
Also I would put this into a new function and make sure it's well tested etc. |
Hi @iamthebot, I'll look into it today if that's okay |
Hey all, I’ve implemented the fast path in The snapshot for the fast path currently looks like this (from the new test case test_run_activation_fast_path):
I’d love some eyes on this to confirm:
After this review, I can clean up the block into a separate function, add comments, etc. Thanks! |
Description
This is a draft PR for discussion of #1696.
For now,
run_activation
simply returnsvariables.current_env
plus variables which can be determined seeing theactivation()
function when there is no conda prefix and no activation scripts, skipping the shell.Opening this PR to discuss whether this approach is acceptable and how we might handle deterministic environment diffs in these cases.