-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add support for layered package cache #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @kelvinou01 - I also started hacking on this a bit but it looks like you are already much further progressed :) Here was my attempt: #998 |
@kelvinou01 is this pr ready? |
it seems the pr does not contains the changes of the config key. |
@gzm55 not yet, is there an urgent need for it? |
no urgent need. but expect this feature for multi-user environment |
when select a read or write cache, can we prefer the one from which we can make a hard link? |
@gzm55 I see how that can be useful! Do you think this feature is necessary to introduce with this PR, or can we do it in a subsequent one as i mentioned above? |
I think a subsequent pr for the feature mentioned above is ok. |
…ered-package-cache
@baszalmstra is there other suggestions about this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Would you be able to fix the merge conflict? We can merge afterwards unless @wolfv has specific comments.
…ttler into feat/layered-package-cache
@baszalmstra done! |
@wolfv Would you be able to take a look at this PR? |
Description
Resolves #43
Stuff to note
PackageCacheError
a#[non_exhaustive]
enum, and modified some variants.Old PR for ref