Skip to content

Conversation

kelvinou01
Copy link
Contributor

@kelvinou01 kelvinou01 commented Dec 23, 2024

Description

Resolves #43

Stuff to note

  • I tried to make this not a break, but alas. Specifically, i made PackageCacheError a #[non_exhaustive] enum, and modified some variants.

Old PR for ref

@kelvinou01 kelvinou01 changed the title Add support for layered package cache feat: add support for layered package cache Dec 23, 2024
@wolfv
Copy link
Contributor

wolfv commented Dec 23, 2024

Hi @kelvinou01 - I also started hacking on this a bit but it looks like you are already much further progressed :)

Here was my attempt: #998

@kelvinou01 kelvinou01 mentioned this pull request Dec 23, 2024
@gzm55
Copy link

gzm55 commented Feb 7, 2025

@kelvinou01 is this pr ready?

@gzm55
Copy link

gzm55 commented Feb 15, 2025

it seems the pr does not contains the changes of the config key.

@kelvinou01
Copy link
Contributor Author

kelvinou01 commented Mar 5, 2025

@kelvinou01 is this pr ready?

@gzm55 not yet, is there an urgent need for it?

@gzm55
Copy link

gzm55 commented Mar 5, 2025

no urgent need. but expect this feature for multi-user environment

@kelvinou01 kelvinou01 marked this pull request as ready for review March 8, 2025 11:43
@kelvinou01
Copy link
Contributor Author

kelvinou01 commented Mar 8, 2025

@wolfv hey, could you help me review this?

Also, I did try implementing storing the capabilities cache like #998. However, I thought this PR was large enough already, so the capabilities cache can be introduced in a subsequent PR.

@gzm55
Copy link

gzm55 commented Mar 9, 2025

when select a read or write cache, can we prefer the one from which we can make a hard link?

@kelvinou01
Copy link
Contributor Author

@gzm55 I see how that can be useful! Do you think this feature is necessary to introduce with this PR, or can we do it in a subsequent one as i mentioned above?

@gzm55
Copy link

gzm55 commented Mar 9, 2025

@gzm55 I see how that can be useful! Do you think this feature is necessary to introduce with this PR, or can we do it in a subsequent one as i mentioned above?

I think a subsequent pr for the feature mentioned above is ok.

@gzm55
Copy link

gzm55 commented Apr 8, 2025

@baszalmstra is there other suggestions about this pr?

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Would you be able to fix the merge conflict? We can merge afterwards unless @wolfv has specific comments.

@kelvinou01
Copy link
Contributor Author

kelvinou01 commented Jul 29, 2025

Would you be able to fix the merge conflict

@baszalmstra done!

@baszalmstra
Copy link
Collaborator

@wolfv Would you be able to take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement layered package caches

4 participants