Skip to content

Change LogSet to macro call instead #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoesters merged 2 commits into from
Dec 15, 2025
Merged

Change LogSet to macro call instead #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc8d67f
Change LogSet to macro call instead
lrandersson Dec 15, 2025
b4d9535
Add news
lrandersson Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions constructor/nsis/main.nsi.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1862,7 +1862,7 @@ Section "Uninstall"
${If} ${FileExists} "$INSTDIR"
# Stop logging or the uninstaller will not remove the install.log file
# without requiring a reboot
LogSet Off
${LogSet} off
RMDir /r /REBOOTOK "$INSTDIR"
${EndIf}
{%- else %}
Expand Down Expand Up @@ -1895,7 +1895,7 @@ Section "Uninstall"

# Stop logging or the uninstaller will not remove the install.log file
# without requiring a reboot
LogSet Off
${LogSet} off
# In case the last command fails, run the slow method to remove leftover
RMDir /r /REBOOTOK "$INSTDIR"

Expand Down
19 changes: 19 additions & 0 deletions news/1141-logset-off
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* EXE: Update calls to built-in function `LogSet` to instead call the intended macro definition `${LogSet}$`. (#1141)

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
Loading