Skip to content

fix: symbolic linking (ln -s) with pre-existing installation #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoesters merged 5 commits into from
Dec 15, 2025
Merged

fix: symbolic linking (ln -s) with pre-existing installation #1135

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c512c0
fix: symbolic linking (`ln -s`) failure with pre-existing installation
dlaehnemann Dec 11, 2025
6918e7b
fix: symbolic linking (`ln -s`) failure with pre-existing installatio…
dlaehnemann Dec 11, 2025
c52c671
docs: add news file
dlaehnemann Dec 11, 2025
f4bc81a
Rename fix-symbolic-linking to 1135-fix-symbolic-linking
marcoesters Dec 15, 2025
99c377a
Apply suggestion from @marcoesters
marcoesters Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion constructor/header.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ chmod +x "$CONDA_EXEC"

{%- if conda_exe_name != "_conda" %}
# In case there are packages that depend on _conda
ln -s "$CONDA_EXEC" "$PREFIX"/_conda
ln -s -f "$CONDA_EXEC" "$PREFIX"/_conda
{%- endif %}

{%- for filename, (start, end, executable) in conda_exe_payloads|items %}
Expand Down
2 changes: 1 addition & 1 deletion constructor/osx/prepare_installation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ chmod +x "$CONDA_EXEC"

{%- if conda_exe_name != "_conda" %}
# In case there are packages that depend on _conda
ln -s "$CONDA_EXEC" "$PREFIX"/_conda
ln -s -f "$CONDA_EXEC" "$PREFIX"/_conda
{%- endif %}

# Create a blank history file so conda thinks this is an existing env
Expand Down
3 changes: 3 additions & 0 deletions news/fix-symbolic-linking
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Bug fixes

* [#1090](https://github.com/conda/constructor/pull/1090) introduced symbolic linking of `_conda`. This fails the whole installer, if the `_conda` file (or link) exists at the target location. [#1135](https://github.com/conda/constructor/pull/1135) fixes this, by forcing (`-f`) the symlink.
Loading