-
Notifications
You must be signed in to change notification settings - Fork 176
Prepare 3.14 #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Prepare 3.14 #1123
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f33be85
Updated authorship for 3.13.2
marcoesters 27a10ed
Updated CHANGELOG for 3.13.2
marcoesters d462ae2
Remove bot authors from release
marcoesters 7fe250b
Update version to 4.0.0
marcoesters 0616f36
Remove breaking change language from changelog and update minor version
marcoesters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -264,7 +264,7 @@ | |
| github: chenghlee | ||
| - name: conda-bot | ||
| email: [email protected] | ||
| num_commits: 56 | ||
| num_commits: 57 | ||
| first_commit: 2022-01-25 21:38:28 | ||
| alternate_emails: | ||
| - [email protected] | ||
|
|
@@ -277,7 +277,7 @@ | |
| aliases: | ||
| - Jaime RGP | ||
| - jaimergp | ||
| num_commits: 110 | ||
| num_commits: 111 | ||
| first_commit: 2022-01-08 14:56:53 | ||
| github: jaimergp | ||
| - name: Tom Hören | ||
|
|
@@ -357,7 +357,7 @@ | |
| github: RahulARanger | ||
| - name: Marco Esters | ||
| email: [email protected] | ||
| num_commits: 57 | ||
| num_commits: 58 | ||
| first_commit: 2023-05-12 11:44:12 | ||
| github: marcoesters | ||
| - name: Darryl Miles | ||
|
|
@@ -372,7 +372,7 @@ | |
| github: deepeshaburse | ||
| - name: pre-commit-ci[bot] | ||
| email: 66853113+pre-commit-ci[bot]@users.noreply.github.com | ||
| num_commits: 66 | ||
| num_commits: 69 | ||
| first_commit: 2023-05-02 12:01:43 | ||
| github: pre-commit-ci[bot] | ||
| - name: Matthias Kuhn | ||
|
|
@@ -382,7 +382,7 @@ | |
| github: m-kuhn | ||
| - name: dependabot[bot] | ||
| email: 49699333+dependabot[bot]@users.noreply.github.com | ||
| num_commits: 53 | ||
| num_commits: 55 | ||
| github: dependabot[bot] | ||
| first_commit: 2024-05-07 10:16:05 | ||
| - name: Julien Jerphanion | ||
|
|
@@ -417,5 +417,5 @@ | |
| - Robin | ||
| github: lrandersson | ||
| email: [email protected] | ||
| num_commits: 5 | ||
| num_commits: 8 | ||
| first_commit: 2025-10-21 08:30:00 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a breaking change, should we at least bump to 3.14? If we should not, is it really a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, breaking changes are usually leading to a bump in the MAJOR version though, not in a MINOR, or even PATCH version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I added this to the news file is that under some circumstances (like using
mambaversion 2), Python is not added to the installer anymore unless requested in theconstructor.yamlfile. I think this is a breaking change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's breaking in the sense of requiring v4, imo. It's a change in how the installer is bootstrapped, but not in a way that would impact users. If the installer implicitly required
pythonbut it was not added as an explicit dependency, it's really unlikely none of the other packages mentioned would have brought it in.In that sense I'm inclined to call this release 3.14, not 4.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds fair to me. Adding Python implicitly was never really a feature, more of a necessary nuisance. It was never really transparent to the user why Python was always added. I removed the breaking change language from the change log.