-
Notifications
You must be signed in to change notification settings - Fork 176
fix: symbolic linking (ln -s) with pre-existing installation
#1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n, also for osx prepare_installation.sh script
|
I'm not sure if it makes sense to add a test case for this and whether this would need to be here, or rather somewhere downstream (e.g. miniforge?). It would basically mean running an installer twice, to ensure the installer works, even if a version of conda already exists... |
|
Pinging @marcoesters , as he reviewed the pull request #1090 that brought in this code. |
I agree that this is niche, especially since the |
marcoesters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Perfect, that was quick. Many thanks! |
Description
This is an issue we came across very far downstream, when using the
setup-minicondaGitHub Action in multiple steps of the same GitHub Actions job implicitly (through thesnakemakeGitHub Action that uses it, which we use for two subsequent steps).Basically, the during first use of the
snakemakeGitHub Action,setup-minicondainstallsminiforgewithout any issues. During the second install, it throws this error:Finding out where that linking actually happens, so where the installers actually take their script code from, was a bit of treasure hunt. But here we are. The code I am suggesting to modify was only recently added in #1090 and thus seems very likely to be the cause of this. But if this forcing of the symlinking does not look like the correct fix to you, I'd be glad to stand corrected.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?