Restore CTRL-C handling by setting new flag in libmamba #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
See for the proper fix upstream too: mamba-org/mamba#2946 |
dholth
changed the title
|
Haven't figured out the correct windows signal incantation yet. |
3 tasks
…amba-solver into pthread-sigmask-ctrl-c
|
libmamba 1.5.3 is out already so we might not need the workaround after all. Let's rerun things. |
|
Is that "skip signal handling" true, or false by default? |
jaimergp
reviewed
Oct 31, 2023
Co-authored-by: jaimergp <[email protected]>
|
Linux and macOS are failing for unrelated reasons (fixed in #347). Windows tests fail because (I hope) the test is not sending the right signal to the subprocess. Need to debug locally. |
dholth
commented
Nov 1, 2023
dholth
changed the title
…nda-libmamba-solver into pthread-sigmask-ctrl-c
jezdez
reviewed
Nov 1, 2023
Co-authored-by: Jannis Leidel <[email protected]>
jaimergp
reviewed
Nov 2, 2023
jezdez
approved these changes
Nov 2, 2023
jaimergp
reviewed
Nov 2, 2023
|
Seems to be working now! I can't test Windows locally but I'm assuming the tests are fine. |
|
Ran the tests on Windows 11 again and confirmed manually the working of CTRL+C to cancel both collecting repodata and solving. |
|
Thanks all! 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mamba-org/mamba#1594 is the issue in Mamba. Possibly for the solver only we could have a second boolean on context init that skipped mamba's pthread call entirely.
Fix #337
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?