Conversation
|
@jaimergp @conda/steering-council please take a look and let me know what you think! |
|
All changes to previous CEPs are cosmetic only. |
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Matt! 🙏
Looks like there are some good fixes in here
Had some questions about some changes, which I didn't quite follow
| * [Default programs in Windows](https://learn.microsoft.com/en-us/windows/win32/shell/default-programs) | ||
| - [Rework linux/osx support plus new simplified format?](https://github.com/conda/menuinst/issues/48) |
There was a problem hiding this comment.
Why is using * for lists unacceptable? Both are valid list formats
There was a problem hiding this comment.
The linter requires that if you start with a given symbol, you have to use the same one all the way through the document.
| ``` | ||
| ```bash |
There was a problem hiding this comment.
Do we always need a language type for code blocks? Sometimes GitHub lacks an appropriate language type for particular code
There was a problem hiding this comment.
Yes. Marking text is fine.
| - `noarch` | ||
| * `weak` |
There was a problem hiding this comment.
Do we know why * or - is preferred? Seems we are switching some to one or the other, but without a clear reason
There was a problem hiding this comment.
See my comment above. Use the same symbol everywhere and you will be fine.
| - For any other types, error out. | ||
| - For regular files: |
There was a problem hiding this comment.
How is linter indentation configured?
There was a problem hiding this comment.
I don't know of setting that sets this.
3 participants
Checklist for submitter
cep-0000.mdnamedcep-XXXX.mdin the root level.All modifications are for style.