Skip to content

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Feb 9, 2026

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pymedm/meta.yaml) and found it was in an excellent condition.

@jGaboardi
Copy link
Member Author

  • seems to actually need a the jaxlib pin after all.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 9, 2026

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pymedm/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pymedm/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python, or selector on line 14:
    skip: True # [win]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21842207259. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pymedm/meta.yaml) and found it was in an excellent condition.

@jGaboardi
Copy link
Member Author

@conda-forge/help-python

This Windows build giving me trouble, and I think I am missing something obvious for adding in some logic that simply skips Windows. In theory, we support Windows, but in practice we do not (and never have) due to the jax compat issues. I have gone through the knowledge base and tried skip: True # [win], etc. But I must be missing the correct combination of additions/removals to get this passing.

@ocefpaf
Copy link
Member

ocefpaf commented Feb 10, 2026

@conda-forge/help-python

This Windows build giving me trouble, and I think I am missing something obvious for adding in some logic that simply skips Windows. In theory, we support Windows, but in practice we do not (and never have) due to the jax compat issues. I have gone through the knowledge base and tried skip: True # [win], etc. But I must be missing the correct combination of additions/removals to get this passing.

The problem is that we do not have jaxlib on Windows. Leave it noarch b/c then that dependency is available, this package will be ready without the need to do anything here.

@jGaboardi
Copy link
Member Author

Yeah, I was digging around the the logs and thought that was the case.

So is the solution here to simply allow the Windows build to fail? And if so, should I add any extra logic in to make the check green?

@ocefpaf
Copy link
Member

ocefpaf commented Feb 10, 2026

So is the solution here to simply allow the Windows build to fail?

Yep. It won't be installable on Windows until that dependency can be satisfied.

@ocefpaf ocefpaf merged commit 3f9d567 into conda-forge:main Feb 10, 2026
5 of 7 checks passed
@jGaboardi
Copy link
Member Author

@ocefpaf, thanks! You are the best!

@jGaboardi jGaboardi deleted the staged_recipe_pymedm branch February 10, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants