-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding pack CLI #31237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding pack CLI #31237
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/pack/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18550527467. Examine the logs at this URL for more detail. |
|
@conda-forge/help-go ready for review! (First contribution. Tried my best to reference the docs) |
|
I've pinged you (the go team) because the pack CLI is built with go, but I've used the built binaries from the releases section in the |
|
@conda-forge/core any guidance would be greatly appreciated! Explanation for why I originally marked the PR as golang above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting! ❤️
In current form, this doesn't follow typical practice, so I suggest revising.
BTW, conda-forge/staged-recipes is the broader team to escalate to if a language-specific team is unresponsive (usually give teams 72 hours between pings/reaching out to others). They is also the Zulip forum that can be more responsive. The conda-forge/core team is often fully occupied with infrastructure and governance issues, so they're unlikely to respond to activity here.
| source: | ||
| url: https://github.com/buildpacks/pack/releases/download/v{{ version }}/pack-v{{ version }}-linux.tgz # [linux] | ||
| url: https://github.com/buildpacks/pack/releases/download/v{{ version }}/pack-v{{ version }}-macos.tgz # [osx] | ||
| url: https://github.com/buildpacks/pack/releases/download/v{{ version }}/pack-v{{ version }}-windows.zip # [win] | ||
| sha256: {{ sha256_linux }} # [linux] | ||
| sha256: {{ sha256_osx }} # [osx] | ||
| sha256: {{ sha256_win }} # [win] | ||
|
|
||
| build: | ||
| number: 0 | ||
| script: | ||
| - mkdir -p $PREFIX/bin # [unix] | ||
| - cp pack $PREFIX/bin/pack # [unix] | ||
| - mkdir -p %PREFIX%\\Scripts # [win] | ||
| - copy pack.exe %PREFIX%\\Scripts\\pack.exe # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, redistributing binaries is not accepted here without explanation. Perhaps it would be helpful to consult previously merged recipes with the go label for reference.
Looking at upstream's GitHub workflow build.yml, they use make to do the builds. So, switching to the source tarball and using make build might be a good place to start.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).