Skip to content

Conversation

@kdavis586
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 16, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pack/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pack/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18550527467. Examine the logs at this URL for more detail.

@kdavis586
Copy link
Author

@conda-forge/help-go ready for review! (First contribution. Tried my best to reference the docs)

@kdavis586
Copy link
Author

I've pinged you (the go team) because the pack CLI is built with go, but I've used the built binaries from the releases section in the meta.yml

@kdavis586
Copy link
Author

@conda-forge/core any guidance would be greatly appreciated!

Explanation for why I originally marked the PR as golang above

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting! ❤️

In current form, this doesn't follow typical practice, so I suggest revising.


BTW, conda-forge/staged-recipes is the broader team to escalate to if a language-specific team is unresponsive (usually give teams 72 hours between pings/reaching out to others). They is also the Zulip forum that can be more responsive. The conda-forge/core team is often fully occupied with infrastructure and governance issues, so they're unlikely to respond to activity here.

Comment on lines +11 to +25
source:
url: https://github.com/buildpacks/pack/releases/download/v{{ version }}/pack-v{{ version }}-linux.tgz # [linux]
url: https://github.com/buildpacks/pack/releases/download/v{{ version }}/pack-v{{ version }}-macos.tgz # [osx]
url: https://github.com/buildpacks/pack/releases/download/v{{ version }}/pack-v{{ version }}-windows.zip # [win]
sha256: {{ sha256_linux }} # [linux]
sha256: {{ sha256_osx }} # [osx]
sha256: {{ sha256_win }} # [win]

build:
number: 0
script:
- mkdir -p $PREFIX/bin # [unix]
- cp pack $PREFIX/bin/pack # [unix]
- mkdir -p %PREFIX%\\Scripts # [win]
- copy pack.exe %PREFIX%\\Scripts\\pack.exe # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, redistributing binaries is not accepted here without explanation. Perhaps it would be helpful to consult previously merged recipes with the go label for reference.

Looking at upstream's GitHub workflow build.yml, they use make to do the builds. So, switching to the source tarball and using make build might be a good place to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants