-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add nvMolKit #31202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add nvMolKit #31202
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/nvmolkit/recipe.yaml:
For recipes/nvmolkit/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18382910856. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please ping team "conda-forge/help-python" |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
conda-forge/help-python |
@conda-forge/help-python ready for review |
As this is is a Python package with some C code, you can also ping @conda-forge/help-python-c |
recipes/nvmolkit/variants.yaml
Outdated
|
||
zip_keys: | ||
- - python | ||
- is_python_min No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to understand, why you specified the cuda version and the python version in the variants.yaml
file ? Tipically version supported by conda-forge are defined in https://github.com/conda-forge/conda-forge-pinning-feedstock, and packages can skip given version (for example, skipping python==3.10 builds by requiring an higher python version).
I see why this may needed due to conda-forge/conda-forge-pinning-feedstock#5719, but do you think it would be possible to drop that for Python and cuda?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks for the info, that pinning package helps me understand the recipe logic better. I've dropped what I can from the variants for now. The CUDA 12.6 default is ok with us, build should work fine if not quite optimal on modern architectures. I'd rather get our first release out with the standard compiler than worry about compatibility.
I tried to pin the python version in recipe.yaml instead but am getting Non noarch packages should have python requirement without any version constraints.
I'm also getting failures in the default linux build, because the cuda compiler version isn't populated. Should I skip the non-CUDA build? Not sure how exactly in the rattler-build recipe format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks for the info, that pinning package helps me understand the recipe logic better. I've dropped what I can from the variants for now. The CUDA 12.6 default is ok with us, build should work fine if not quite optimal on modern architectures. I'd rather get our first release out with the standard compiler than worry about compatibility.
In the feedstock we have a build configuration that tries to target all supported versions of CUDA to maximize the platforms over which it can be installed. Users on systems that support the newest version of CUDA should automatically get the version built for newest CUDA target, and users with older systems will still have the ability to install the package though they will obviously experience lower performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I applied the recommended fix with a small syntax change. I also removed the python version limit. Given the default builds of conda-forge are only off by 1 from my initial support matrix, it's not hard to extend to all 4 python versions and makes things easier.
Thanks!
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/nvmolkit/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18593847388. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
All comments so far are addressed! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).