-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding conda-recipe-manager as a conda-forge feedstock #26371
Adding conda-recipe-manager as a conda-forge feedstock #26371
Conversation
- This will allow us to start publishing versions that others can consume - The most immediate need is for an [ask in Grayskull](conda/grayskull#486)
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/conda-recipe-manager:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/conda-recipe-manager:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/conda-recipe-manager:
|
…xample in documentation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python I believe this is ready for review. Thanks! |
recipes/conda-recipe-manager/LICENSE
Outdated
@@ -0,0 +1,32 @@ | |||
BSD 3-Clause License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this file is already in the source distribution you're using so you shouldn't include an additional copy of it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'm confused then because every piece of documentation I saw says to include it with the recipe file. I thought that was standard practice.
staged-recipes/recipes/example/meta.yaml
Lines 52 to 55 in a504af8
# It is strongly encouraged to include a license file in the package, | |
# (even if the license doesn't require it) using the license_file entry. | |
# See http://conda.pydata.org/docs/building/meta-yaml.html#license-file | |
license_file: LICENSE.txt |
# It is strongly encouraged to include a license file in the package,
# (even if the license doesn't require it) using the license_file entry.
# See http://conda.pydata.org/docs/building/meta-yaml.html#license-file
license_file: LICENSE.txt
https://conda-forge.org/docs/maintainer/adding_pkgs/#the-staging-process
With the help of the staging process, add a package's recipe and license to the staged-recipes repository and create a PR.
https://conda-forge.org/docs/maintainer/adding_pkgs/#checklist
Ensure that you have included a license file if your license requires one – most do. (see here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, you are correct that this means that it should be included. Most packages package the license file in the source distribution, the file then just needs to list it in the meta.yaml and it is included. You only need to manually include the license file if it isn't included.
So the difference comes from including the actual file (which is often not necessary) and including the path to the file (which is always necessary).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification! Maybe the docs or linter could be improved to reflect that nuance?
Either way, I just removed the file in the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think there is an issue for that, we just haven't gotten around to it... 😄
I'm not sure how to get the bot to change the label, but I, as the author, made a contribution last week and I don't think the label is accurate anymore. |
For the future, you can just change the label by requesting a review again using @ conda-forge/help-python |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).