-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gtsam - take 3 #17997
Add gtsam - take 3 #17997
Conversation
…1.1_with_boost_1.7.4
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Opened a new PR as I didn't have write access in the other PRs. This PR fixes some missing run deps on boost-cpp and adds required tests. /cc @wolfv |
Cool! |
I am not sure what's going on with boost on Windows @wolfv - I'm suggesting to skip Windows for now and open an issue in the feedstock, unless you want to play around with the Win build? |
It's ready to go :) |
I'm giving up on osx, no idea why it still finds the wrong python .. skip as well? Maybe it'll magically work in the feedstock? |
in the last build cmake reports python 3.8 as found?
|
Ah thank goodness. I thought I still saw the system python somewhere. This is ready for merge :) |
awesome! |
Thanks for following up on this @Tobias-Fischer and @wolfv . I had forgotten about this. :P |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).Fix #14339 #15578