Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gtsam - take 3 #17997

Merged
merged 30 commits into from
Feb 11, 2022
Merged

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Feb 10, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Fix #14339 #15578

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gtsam) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

Opened a new PR as I didn't have write access in the other PRs. This PR fixes some missing run deps on boost-cpp and adds required tests.

/cc @wolfv

@wolfv
Copy link
Member

wolfv commented Feb 10, 2022

Cool!

@Tobias-Fischer
Copy link
Contributor Author

I am not sure what's going on with boost on Windows @wolfv - I'm suggesting to skip Windows for now and open an issue in the feedstock, unless you want to play around with the Win build?

@Tobias-Fischer
Copy link
Contributor Author

It's ready to go :)

@Tobias-Fischer
Copy link
Contributor Author

I'm giving up on osx, no idea why it still finds the wrong python .. skip as well? Maybe it'll magically work in the feedstock?

@wolfv
Copy link
Member

wolfv commented Feb 11, 2022

in the last build cmake reports python 3.8 as found?

-- Python toolbox flags                                      
--  Build Python module with pybind                  : Enabled
--  Python version                                   : 3.8
-- ===============================================================

@Tobias-Fischer
Copy link
Contributor Author

Ah thank goodness. I thought I still saw the system python somewhere. This is ready for merge :)

@wolfv wolfv merged commit 89dce65 into conda-forge:main Feb 11, 2022
@wolfv
Copy link
Member

wolfv commented Feb 11, 2022

awesome!

@Tobias-Fischer Tobias-Fischer deleted the gtsam_4.0.3_with_boost_1.7.6 branch February 11, 2022 19:59
@ameysutavani
Copy link
Contributor

Thanks for following up on this @Tobias-Fischer and @wolfv . I had forgotten about this. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants