Conversation
Upgrade to PyQt6 6.8.1
…5.12.25.01.57.59 Other tools: - conda-build 25.7.0 - rattler-build 0.45.0 - rattler-build-conda-compat 1.4.5
Retry pyqt6 build after pyqt6-builder update
|
Hi! This is the friendly automated conda-forge-webservice. It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details. Please close this pull request and remake it from a fork of this feedstock. Have a great day! |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21886194637. Examine the logs at this URL for more detail. |
Indeed, that's what I meant, thanks! We can then create a |
Sounds good. I don't have maintenance powers for this feedstock. Are you (or anyone else) able to take care of that? |
|
Moving this to draft to give people a bit more time to test and report errors with the new packages (see #163 for instance). |
Fix cross-compilation for osx-arm64
|
On a second thought, I (as one of feedstock maintainers) would prefer to maintain
|
|
Thanks for understanding @JarrettSJohnson! |
That's incorrect. What is on Now, you can still argue of course that qt6 is not ready to be the default (e.g. for pyqt, v6 support is still relatively recent), but merging |
Sure, that would work too but no one suggested to do it. So, I thought
Sorry, I missed that one.
That's what I did (i.e. lack of WebEngine packages). But if a |
I did suggest that :)
Sounds good! Should we just reopen this PR? In any case, I can offer to help with the necessary git resp. feedstock operations. |
|
Hi! This is the friendly automated conda-forge-webservice. It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details. Please close this pull request and remake it from a fork of this feedstock. Have a great day! |
I just saw that you indeed did it, sorry again. But shouldn't the branch be created before merging this PR? |
(Dont mind me jumping in here) I can't make the branch since I'm not a maintainer--I just reopened this PR assuming one of you would make the branch before merging this. |
A branch is just a commit that gets a special reference, which can be added at any time (even for past commits, see the docs). I generally recommend creating branches after a relevant PR has been merged. Otherwise it happens with some regularity that someone creates a branch in anticipation of an "imminent" merge, only for the PR to be delayed by unforeseen problems, while other changes continue flowing into main, and then it becomes more of a hassle to keep the history sane.
My offer stands to create the branch; my hope would be though that the (recently updated) docs are good enough that @ccordoba12 would feel empowered to do it himself 🙃 |
I'd prefer for you to do it, if that's ok. The reason I'm always behind in my duties as feedstock maintainer (other than merging update PRs) is that my role as Spyder lead maintainer takes almost all my time. |
ccordoba12
left a comment
There was a problem hiding this comment.
Approving this just to confirm I agree with this PR.
|
Hi! This is the friendly automated conda-forge-webservice. It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details. Please close this pull request and remake it from a fork of this feedstock. Have a great day! |
|
Sorry, this somehow slipped my radar, I just got reminded of this by something else again. Here's the brandnew So let's merge this. :) |
|
Please don't press the big purple button here to delete the branch yet, but rather check out conda-forge/admin-requests#1907 :) |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)@h-vetinari , was this what you proposed (merging
qt6intomain)?