NEW: Add tegra variant for CUDA 12.9 #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterbox
requested review from
a team,
jakirkham and
leofang
as code owners
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jakirkham
reviewed
Jan 6, 2026
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Daniel! 🙏
Had one comment below
Otherwise LGTM
Comment on lines
+10
to
+36
| # Convert CUDAARCHS to NVCC_GENCODE if available | ||
| if [[ -n "${CUDAARCHS}" ]]; then | ||
| NVCC_GENCODE="" | ||
| IFS=';' read -ra ARCHS <<< "$CUDAARCHS" | ||
| for arch_spec in "${ARCHS[@]}"; do | ||
| # Remove any leading/trailing whitespace | ||
| arch_spec=$(echo "$arch_spec" | xargs) | ||
|
|
||
| # Parse architecture number and suffix (e.g., "87-real", "101f-virtual") | ||
| if [[ "$arch_spec" =~ ^([0-9]+)([a-z]*)-(real|virtual)$ ]]; then | ||
| arch_num="${BASH_REMATCH[1]}" | ||
| arch_suffix="${BASH_REMATCH[2]}" | ||
| code_type="${BASH_REMATCH[3]}" | ||
|
|
||
| # Build the full architecture string with suffix if present | ||
| full_arch="${arch_num}${arch_suffix}" | ||
|
|
||
| if [[ "$code_type" == "real" ]]; then | ||
| NVCC_GENCODE="${NVCC_GENCODE} -gencode=arch=compute_${full_arch},code=sm_${full_arch}" | ||
| elif [[ "$code_type" == "virtual" ]]; then | ||
| NVCC_GENCODE="${NVCC_GENCODE} -gencode=arch=compute_${arch_num},code=compute_${arch_num}" | ||
| fi | ||
| fi | ||
| done | ||
| # Trim leading space | ||
| export NVCC_GENCODE="${NVCC_GENCODE# }" | ||
| fi |
Member
There was a problem hiding this comment.
Discussed this block with Daniel offline, our plan is to move this into the nvcc feedstock as another variable
Member
Author
There was a problem hiding this comment.
Upstream relevant code for choosing NVCC_GENCODE:
https://github.com/NVIDIA/nccl/blob/1e0c869c39bb33f1034cb9920bd2a8a8406f04a3/makefiles/common.mk#L34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)