Fixed pytorch version for torchvision#1135
Fixed pytorch version for torchvision#1135shubham1206agra wants to merge 1 commit intoconda-forge:mainfrom
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
left a comment
There was a problem hiding this comment.
Making pytorch version complaint to https://github.com/pytorch/vision?tab=readme-ov-file#installation
Do you mean "comply" instead of "complain(t)"?
In any case, this PR is wrong. For details you can see conda-forge/torchvision-feedstock#135.
If you're concerned about the warning, you can open a PR that patches it out (removes it so it cannot appear).
My bad for typo. Fixed it.
If I am not mistaken, this issue advises us not to strictly pin torchvision to a specific PyTorch version. However, I am unable to install torchvision 0.23 with PyTorch 2.8.0, which is recommended in https://github.com/pytorch/vision?tab=readme-ov-file#installation. So, I believe the fix should be made from here. Error |
This is explained in the issue I linked
This is because, for various reasons conda-forge/torchvision-feedstock#125 was merged after conda-forge/torchvision-feedstock#127
It cannot be fixed here. Changing the constraints as you propose would just lead to broken packages. The solution is to apply conda-forge/torchvision-feedstock#125 to a maintenance branch for 0.23 |
|
The issue is now fixed |
Checklist
generate_patch_json.pyif absolutely necessary.pre-commit run -aand ensured all files pass the linting checks.python show_diff.pyand posted the output as part of the PR.Making PyTorch version complaint to https://github.com/pytorch/vision?tab=readme-ov-file#installation
python show_diff.py output