Skip to content

add migration for pytorch 2.8#7713

Merged
conda-forge-admin merged 2 commits intoconda-forge:mainfrom
das-intensity:pytorch28
Oct 1, 2025
Merged

add migration for pytorch 2.8#7713
conda-forge-admin merged 2 commits intoconda-forge:mainfrom
das-intensity:pytorch28

Conversation

@das-intensity
Copy link
Contributor

Adding migration for pytorch 2.8 as it's been out for almost 3 weeks now.

We still have the migration for 2.7 active https://conda-forge.org/status/migration/?name=pytorch27 so I've pinned this to wait on that one.

However since those package PRs have been WIP for ~3months, I suspect we should just close out that migration.

@das-intensity das-intensity requested a review from a team as a code owner August 26, 2025 18:36
@das-intensity
Copy link
Contributor Author

@h-vetinari @jeongseok-meta what do you think? Ok to cancel pytorch27 migration in favor of this? Do I just delete the migration yaml? I've never closed out a migration before.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Probably it make sense to first package PyTorch 2.8 before starting a migration for it (see conda-forge/pytorch-cpu-feedstock#409)?

@das-intensity
Copy link
Contributor Author

@traversaro ahh yes you're right, I saw https://anaconda.org/conda-forge/pytorch show 2.8.0 and figured it'd been migrated, but I see conda-forge/pytorch-cpu-feedstock#410 - will convert to draft until conda-forge/pytorch-cpu-feedstock#409 lands.

@das-intensity das-intensity marked this pull request as draft August 26, 2025 22:19
@das-intensity das-intensity marked this pull request as ready for review October 1, 2025 06:38
@das-intensity
Copy link
Contributor Author

Re-opened as conda-forge::pytorch has updated to 2.8

@h-vetinari h-vetinari mentioned this pull request Oct 1, 2025
9 tasks
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent #7821 so we can start this on a clean slate. Thanks!

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Oct 1, 2025
@conda-forge-admin conda-forge-admin merged commit 26fc1f6 into conda-forge:main Oct 1, 2025
3 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • github-actions: passed

Thus the PR was passing and merged! Have a great day!

@Luthaf
Copy link
Contributor

Luthaf commented Oct 2, 2025

I have one question about this migration: it looks like pytorch is properly pinned and pulled at version 2.8, but this is not the case for libtorch:

Could it be that libtorch is not properly handled while pytorch is?

@h-vetinari
Copy link
Member

That's because the recipe

  host:
    - libmetatensor >=0.1.15,<0.2
    # We build against the CPU version of torch to not have to deal with CUDA
    # compilers (torch's CMake targets tries to find CUDA compilers even when
    # there is no CUDA code to build). This does not impact the `run`
    # dependency, since libtorch `run_exports` are variant agnostic
    - libtorch * cpu*

does not have a pin that the bot recognizes. You have to add a bare - libtorch line for the pinning to take hold.

@Luthaf
Copy link
Contributor

Luthaf commented Oct 2, 2025

Ok, that makes sense, I'll have a look. I guess I can add both - libtorch and - libtorch * cpu* in there. Thanks!

@h-vetinari
Copy link
Member

Ah, I had forgotten that there had been an open issue that I still wanted to fix before the migration: conda-forge/cudnn-feedstock#124

I think we need to lift the cudnn pin for the migration to actually work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants