add migration for pytorch 2.8#7713
Conversation
|
@h-vetinari @jeongseok-meta what do you think? Ok to cancel pytorch27 migration in favor of this? Do I just delete the migration yaml? I've never closed out a migration before. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Probably it make sense to first package PyTorch 2.8 before starting a migration for it (see conda-forge/pytorch-cpu-feedstock#409)? |
|
@traversaro ahh yes you're right, I saw https://anaconda.org/conda-forge/pytorch show 2.8.0 and figured it'd been migrated, but I see conda-forge/pytorch-cpu-feedstock#410 - will convert to draft until conda-forge/pytorch-cpu-feedstock#409 lands. |
9473b9f to
3d528d8
Compare
|
Re-opened as |
h-vetinari
left a comment
There was a problem hiding this comment.
I sent #7821 so we can start this on a clean slate. Thanks!
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
|
I have one question about this migration: it looks like
Could it be that |
|
That's because the recipe host:
- libmetatensor >=0.1.15,<0.2
# We build against the CPU version of torch to not have to deal with CUDA
# compilers (torch's CMake targets tries to find CUDA compilers even when
# there is no CUDA code to build). This does not impact the `run`
# dependency, since libtorch `run_exports` are variant agnostic
- libtorch * cpu*does not have a pin that the bot recognizes. You have to add a bare |
|
Ok, that makes sense, I'll have a look. I guess I can add both |
|
Ah, I had forgotten that there had been an open issue that I still wanted to fix before the migration: conda-forge/cudnn-feedstock#124 I think we need to lift the cudnn pin for the migration to actually work |
Adding migration for pytorch 2.8 as it's been out for almost 3 weeks now.
We still have the migration for 2.7 active https://conda-forge.org/status/migration/?name=pytorch27 so I've pinned this to wait on that one.
However since those package PRs have been WIP for ~3months, I suspect we should just close out that migration.