Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update CF stack template for new staging stack #1068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Update CF stack template for new staging stack #1068

wants to merge 1 commit into from

Conversation

433eros
Copy link
Contributor

@433eros 433eros commented Mar 15, 2023

The LARA CloudFormation stack template needed to be tweaked quite a bit to add new stuff for the new staging environment stack

@433eros 433eros requested review from scytacki and dougmartin March 15, 2023 17:39
scytacki
scytacki requested changes Mar 18, 2023
View reviewed changes
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me a link so I can see what has been changed?

There might be a better way, but here is one:

  • add the original LARA cf stack template in a first commit
  • then add a second commit with this file

Then I can look at the second commit to see the diff.

@dougmartin dougmartin removed their request for review March 27, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scytacki scytacki scytacki requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@433eros @scytacki