-
Notifications
You must be signed in to change notification settings - Fork 5
Test against pre-release of 3.14 #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 7 7
Lines 894 894
Branches 121 121
=======================================
Hits 820 820
Misses 53 53
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
potentially identified problem in matplotlib.tox/py/lib/python3.14/site-packages/con_duct/suite/main.py:9: in execute
result = args.func(args)
.tox/py/lib/python3.14/site-packages/con_duct/suite/plot.py:42: in matplotlib_plot
ax1.legend(loc="upper left")
.tox/py/lib/python3.14/site-packages/matplotlib/axes/_axes.py:342: in legend
self.legend_ = mlegend.Legend(self, handles, labels, **kwargs)
.tox/py/lib/python3.14/site-packages/matplotlib/legend.py:563: in __init__
self._init_legend_box(handles, labels, markerfirst)
.tox/py/lib/python3.14/site-packages/matplotlib/legend.py:910: in _init_legend_box
handle_list.append(handler.legend_artist(self, orig_handle,
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:129: in legend_artist
artists = self.create_artists(legend, orig_handle,
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:303: in create_artists
self.update_prop(legline, orig_handle, legend)
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:88: in update_prop
self._update_prop(legend_handle, orig_handle)
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:79: in _update_prop
self._default_update_prop(legend_handle, orig_handle)
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:84: in _default_update_prop
legend_handle.update_from(orig_handle)
.tox/py/lib/python3.14/site-packages/matplotlib/lines.py:1357: in update_from
self._marker = MarkerStyle(marker=other._marker)
.tox/py/lib/python3.14/site-packages/matplotlib/markers.py:248: in __init__
self._set_marker(marker)
.tox/py/lib/python3.14/site-packages/matplotlib/markers.py:323: in _set_marker
self.__dict__ = copy.deepcopy(marker.__dict__)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:140: in deepcopy
y = copier(x, memo)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:211: in _deepcopy_dict
y[deepcopy(key, memo)] = deepcopy(value, memo)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:147: in deepcopy
y = copier(memo)
.tox/py/lib/python3.14/site-packages/matplotlib/path.py:285: in __deepcopy__
p = copy.deepcopy(super(), memo)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:166: in deepcopy
y = _reconstruct(x, memo, *rv)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:243: in _reconstruct
y = func(*args)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:[242](https://github.com/con/duct/actions/runs/12188541632/job/34001753713#step:5:243): in <genexpr>
args = (deepcopy(arg, memo) for arg in args)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:147: in deepcopy
y = copier(memo)
E RecursionError: maximum recursion depth exceeded
!!! Recursion detected (same locals & position)needs to be checked with matplotlib |
|
Looks like this is already filed as an upstream issue: Open PR to workaround in matplotlib. Converted to draft since we cant really do anything with this until its resolved. |
|
How urgent is this to get resolved sooner rather than later for you? |
|
@tacaswell I think not urgent until the 3.14 GA is close. Do you need help upstream? |
|
I'm open to suggestions for a better solution than matplotlib/matplotlib#29393 ! My current plan was to hold off on getting that merged into Matplotlib until we got to the CPython betas and/or we got guidance from upstream if the change is going to be reverted, accounted for, or documented as a break. However, if you had a pressing need (and are willing to run from the mpl main branch) I am open to merging it sooner rather than later. |
|
Fixed upstream, but not released yet. |
🧪 CI InsightsHere's what we observed from your CI run for 33c0b43. 🟢 All jobs passed!But CI Insights is watching 👀 |
Python 3.14 defaults to forkserver instead of fork which requires picklable functions, so we move local runners to module level. https://docs.python.org/3.14/whatsnew/3.14.html Co-Authored-By: Claude <noreply@anthropic.com>
|
woohoo! |
|
coolio, thanks @asmacdo ! |
|
🚀 PR was released in |
Estimate: 3.14.0 final: Wednesday, 2025-10-01
Release schedule: https://peps.python.org/pep-0745/