Skip to content

Conversation

@yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Dec 5, 2024

Estimate: 3.14.0 final: Wednesday, 2025-10-01
Release schedule: https://peps.python.org/pep-0745/

@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.72%. Comparing base (1af9eb1) to head (33c0b43).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files           7        7           
  Lines         894      894           
  Branches      121      121           
=======================================
  Hits          820      820           
  Misses         53       53           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic yarikoptic added the semver-tests Add or improve existing tests label Dec 5, 2024
@yarikoptic
Copy link
Member Author

potentially identified problem in matplotlib
.tox/py/lib/python3.14/site-packages/con_duct/suite/main.py:9: in execute
    result = args.func(args)
.tox/py/lib/python3.14/site-packages/con_duct/suite/plot.py:42: in matplotlib_plot
    ax1.legend(loc="upper left")
.tox/py/lib/python3.14/site-packages/matplotlib/axes/_axes.py:342: in legend
    self.legend_ = mlegend.Legend(self, handles, labels, **kwargs)
.tox/py/lib/python3.14/site-packages/matplotlib/legend.py:563: in __init__
    self._init_legend_box(handles, labels, markerfirst)
.tox/py/lib/python3.14/site-packages/matplotlib/legend.py:910: in _init_legend_box
    handle_list.append(handler.legend_artist(self, orig_handle,
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:129: in legend_artist
    artists = self.create_artists(legend, orig_handle,
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:303: in create_artists
    self.update_prop(legline, orig_handle, legend)
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:88: in update_prop
    self._update_prop(legend_handle, orig_handle)
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:79: in _update_prop
    self._default_update_prop(legend_handle, orig_handle)
.tox/py/lib/python3.14/site-packages/matplotlib/legend_handler.py:84: in _default_update_prop
    legend_handle.update_from(orig_handle)
.tox/py/lib/python3.14/site-packages/matplotlib/lines.py:1357: in update_from
    self._marker = MarkerStyle(marker=other._marker)
.tox/py/lib/python3.14/site-packages/matplotlib/markers.py:248: in __init__
    self._set_marker(marker)
.tox/py/lib/python3.14/site-packages/matplotlib/markers.py:323: in _set_marker
    self.__dict__ = copy.deepcopy(marker.__dict__)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:140: in deepcopy
    y = copier(x, memo)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:211: in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:147: in deepcopy
    y = copier(memo)
.tox/py/lib/python3.14/site-packages/matplotlib/path.py:285: in __deepcopy__
    p = copy.deepcopy(super(), memo)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:166: in deepcopy
    y = _reconstruct(x, memo, *rv)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:243: in _reconstruct
    y = func(*args)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:[242](https://github.com/con/duct/actions/runs/12188541632/job/34001753713#step:5:243): in <genexpr>
    args = (deepcopy(arg, memo) for arg in args)
/opt/hostedtoolcache/Python/3.14.0-alpha.2/x64/lib/python3.14/copy.py:147: in deepcopy
    y = copier(memo)
E   RecursionError: maximum recursion depth exceeded
!!! Recursion detected (same locals & position)

needs to be checked with matplotlib

@asmacdo asmacdo marked this pull request as draft January 14, 2025 20:35
@asmacdo
Copy link
Member

asmacdo commented Jan 14, 2025

Looks like this is already filed as an upstream issue:
matplotlib/matplotlib#29393

Open PR to workaround in matplotlib.
python/cpython#126817

Converted to draft since we cant really do anything with this until its resolved.

@tacaswell
Copy link

How urgent is this to get resolved sooner rather than later for you?

@asmacdo
Copy link
Member

asmacdo commented Jan 30, 2025

@tacaswell I think not urgent until the 3.14 GA is close. Do you need help upstream?

@tacaswell
Copy link

I'm open to suggestions for a better solution than matplotlib/matplotlib#29393 !

My current plan was to hold off on getting that merged into Matplotlib until we got to the CPython betas and/or we got guidance from upstream if the change is going to be reverted, accounted for, or documented as a break. However, if you had a pressing need (and are willing to run from the mpl main branch) I am open to merging it sooner rather than later.

@asmacdo
Copy link
Member

asmacdo commented Jul 21, 2025

Fixed upstream, but not released yet.

@mergify
Copy link

mergify bot commented Sep 4, 2025

🧪 CI Insights

Here's what we observed from your CI run for 33c0b43.

🟢 All jobs passed!

But CI Insights is watching 👀

Python 3.14 defaults to forkserver instead of fork which
requires picklable functions, so we move local runners to
module level.

https://docs.python.org/3.14/whatsnew/3.14.html

Co-Authored-By: Claude <noreply@anthropic.com>
@asmacdo
Copy link
Member

asmacdo commented Sep 4, 2025

woohoo!

@asmacdo asmacdo marked this pull request as ready for review September 4, 2025 17:56
@yarikoptic yarikoptic merged commit b8b69ce into main Sep 4, 2025
17 checks passed
@yarikoptic
Copy link
Member Author

coolio, thanks @asmacdo !

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

🚀 PR was released in v0.16.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released semver-tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants