Package page reflow - #1844
Conversation
|
Why not push the README and current version content where you put the 3 boxes, and move the boxes's data in the right panel ? Right now the Security and Fund package maintenance cards are quite empty and lead to empty space again |
IonBazan
left a comment
IonBazan
left a comment
There was a problem hiding this comment.
I agree with @EdouardCourty - especially for PIE packages, funding and security info will waste too much space. I would take some inspiration from #1750 and move the stats below the name instead. Stars, Forks, Issues and Website could be easily replaced with icons and placed inline to save space like it's done in https://packagist.shyim.workers.dev/p/symfony/console. That design has its flaws but I like the "stats strip" with License, Dependencies, PHP version etc.
| {% endif %} | ||
| <div class="row package-facts"> | ||
| <div class="col-12 col-md-6 col-lg"> | ||
| <div class="package-aside details"> |
There was a problem hiding this comment.
While here, we could add .facts here too. That should solve #1817
There was a problem hiding this comment.
Hah yeah I just noticed that problem as well and got a fix locally :)
|
I mean just as a reference.. this is the amount of empty space we have today :D So I think it's a lot better already, and yes the security block is a bit empty right now but that may have more later. Anyway I will do some more improvements to gain a few more vertical pixels, but moving the readme on top is IMO a no-go because the length of the readme is very unpredictable. |
|
How about we move version info and readme within that Left column itself? Currently it starts only after "facts-boxes" but we could treat that whole right section as a sidebar. The consequence would be that readme has a little less horizontal space, and responsiveness could be a bit more tricky but maybe worth a shot. Something like this: Looks a bit too crowded but with right paddings should render quite well. |
|
Yeah problem with that is if you want to go through a few versions to see how metadata changed, the version list might require you to scroll so far that you do not see the version metadata anymore, and then you have to scroll back and forth. So nope from me. Anyway I'll deploy this PR already and then see. I don't really want to go down the rabbit hole of redesigning everything right now as I have lots of other stuff I gotta work on too. |
|
before after |
|
Looks good, and I love the maintainer controls collapsed into dropdowns 👏🏻 |
3 participants
Not really a huge redesign but trying to make things flow a bit better to avoid this huge gap between description and version info, that leads to wasted vertical space..