Add the missing LIMIT 1 to findLatestExecutedJob - #1840
Merged
Conversation
The query only ever consumes one row - it is fed to fetchOne() - but had no LIMIT, so MySQL sorted every matching job row before discarding all but the first. Job volume per package is low enough that this was never expensive, hence no new index, but the LIMIT is free and matches findLatestMigrationJob() right above it, which already uses setMaxResults(1) for the same shape of query. The new tests pin the ordering semantics the LIMIT relies on: newest executed job wins, queued jobs and other packages/types are not considered.
stof
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query only ever consumes one row — it's fed to
fetchOne()— but had noLIMIT, so MySQL sorted every matching job row before discarding all but the first.Job volume per package is low enough that this was never expensive, hence no new index. The
LIMITis free though, and it matchesfindLatestMigrationJob()immediately above it, which already usessetMaxResults(1)for the same shape of query.The new tests pin the ordering semantics the
LIMITrelies on — newest executed job wins, queued jobs and other packages/types are not considered — since a wrongLIMITon an unstable sort is the failure mode worth guarding.Verification
composer phpstanclean, full suite green.