adapt to changes in JitCall, use InvokeConstructor in CallWrapper,
#149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Jun 12, 2025
clingwrapper/src/clingwrapper.cxx
Outdated
| }); | ||
| } else if (JC.getKind() == Cpp::JitCall::kConstructorCall) { | ||
| invokeHelper([&](void** buf, size_t count) { | ||
| JC.InvokeConstructor(result, 1UL, {buf, count}, self); |
There was a problem hiding this comment.
I thought that case can still go via Invoke.
There was a problem hiding this comment.
correct, the culprit was https://github.com/compiler-research/CppInterOp/blob/5274fd8f517bcd94104dd31d022daf08e1071c19/include/CppInterOp/CppInterOp.h#L176 where the !args.m_Args condition for destructors was checked for ctor calls. Thanks for catching that, I have updated the InterOp PR
vgvassilev
reviewed
Jun 12, 2025
| } | ||
| }; | ||
|
|
||
| invokeHelper( |
There was a problem hiding this comment.
We probably do not need the lambda if we call things only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of compiler-research/CppInterOp#587 that prevents crashes in cppyy when calling
Invokewith a constructor