fix build instructions in readme#832
Closed
codegallivant wants to merge 1 commit intocompiler-research:mainfrom
Closed
fix build instructions in readme#832codegallivant wants to merge 1 commit intocompiler-research:mainfrom
codegallivant wants to merge 1 commit intocompiler-research:mainfrom
Conversation
Collaborator
This was fixed by #829, so this addition is no longer required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: Building CppInterOp using original README instructions results in an error.
Upon viewing logs, we observe -
Cause: Since the build type is not set, it results in an invalid argument being given downstream.
Solution: Add
-DCMAKE_BUILD_TYPE=Releaseflag to README in the command to build CppInterOp.Type of change
Please tick all options which are relevant.
Testing
The build procedure works when you specify the flag.
Checklist