Skip to content

[ci] Use dated ROOT/llvm tag to build Cling 1.3#827

Merged
aaronj0 merged 2 commits intocompiler-research:mainfrom
aaronj0:fix-cling1.3-llvm
Feb 28, 2026
Merged

[ci] Use dated ROOT/llvm tag to build Cling 1.3#827
aaronj0 merged 2 commits intocompiler-research:mainfrom
aaronj0:fix-cling1.3-llvm

Conversation

@aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented Feb 27, 2026

ROOT's development workflow between cling and the LLVM fork are slightly different. We cannot rely on a version of cling that was released at a fixed point in time to reliably work with llvm's cling-llvm20 tag which is a moving target as development will continue after the 1.3 release (1.2 had the same issue, see root-project/cling#556). Based on my understanding, we should probably use the dated tag cling-llvm20-20260119-01. I will bump this based on the cppyy migration status (which is the main usecase of having cppyy-cling jobs on our CI in the first place)

@aaronj0
Copy link
Collaborator Author

aaronj0 commented Feb 27, 2026

@mcbarton I believe these changes won't trigger a rebuild unless the cling cache is deleted.. Can you take a look? Thanks!

@mcbarton
Copy link
Collaborator

@aaronj0 I won't have time to review this, as I go on annual leave today. If you want the cache to follow your dated root-llvm-tag, then you'll need to set CLING_HASH in the ci accordingly. You'll also need to update the documentation to use these dated commits. Hope this helps fix the ci. You'll probably want to recheck the tests in this issue as part of this work #808

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (a08033c) to head (5dc3193).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          11       11           
  Lines        4012     4012           
=======================================
  Hits         3192     3192           
  Misses        820      820           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaronj0
Copy link
Collaborator Author

aaronj0 commented Feb 27, 2026

@aaronj0 I won't have time to review this, as I go on annual leave today. If you want the cache to follow your dated root-llvm-tag, then you'll need to set CLING_HASH in the ci accordingly. You'll also need to update the documentation to use these dated commits. Hope this helps fix the ci. You'll probably want to recheck the tests in this issue as part of this work #808

No worries, thanks alot!

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the first and last commits are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants