Skip to content

Remove -sSUPPORT_LONGJMP=wasm and use of EMCC_CFLAGS when building xeus-cpp#803

Merged
mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton:test-xeus-cpp-configuration-PR
Feb 17, 2026
Merged

Remove -sSUPPORT_LONGJMP=wasm and use of EMCC_CFLAGS when building xeus-cpp#803
mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton:test-xeus-cpp-configuration-PR

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Feb 6, 2026

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (be35eb6) to head (53e6101).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #803   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          11       11           
  Lines        4012     4012           
=======================================
  Hits         3192     3192           
  Misses        820      820           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton force-pushed the test-xeus-cpp-configuration-PR branch from cba069d to 9e987ec Compare February 17, 2026 09:42
@mcbarton mcbarton changed the title Test 'Make exception handling models better configurable for the wasm kernel' PR in xeus-cpp against CppInterOps ci Remove -sSUPPORT_LONGJMP=wasm and use of EMCC_CFLAGS when building xeus-cpp Feb 17, 2026
@mcbarton mcbarton force-pushed the test-xeus-cpp-configuration-PR branch from 9e987ec to 53e6101 Compare February 17, 2026 09:43
@mcbarton mcbarton marked this pull request as ready for review February 17, 2026 09:43
@mcbarton mcbarton requested a review from anutosh491 February 17, 2026 09:43
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect emscripten to enable this -sSUPPORT_LONGJMP=wasm by default when we use wasm exceptions, so this should do !

@mcbarton mcbarton merged commit 59d5ab3 into compiler-research:main Feb 17, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants