Remove -sSUPPORT_LONGJMP=wasm and use of EMCC_CFLAGS when building xeus-cpp#803
Merged
mcbarton merged 1 commit intocompiler-research:mainfrom Feb 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 11 11
Lines 4012 4012
=======================================
Hits 3192 3192
Misses 820 820 🚀 New features to boost your workflow:
|
cba069d to
9e987ec
Compare
9e987ec to
53e6101
Compare
anutosh491
approved these changes
Feb 17, 2026
Collaborator
anutosh491
left a comment
There was a problem hiding this comment.
We expect emscripten to enable this -sSUPPORT_LONGJMP=wasm by default when we use wasm exceptions, so this should do !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist