Skip to content

Add raytracer notebook to deployment#786

Merged
mcbarton merged 3 commits intocompiler-research:mainfrom
mcbarton:Add-raytracer-notebook-to-deployment
Jan 26, 2026
Merged

Add raytracer notebook to deployment#786
mcbarton merged 3 commits intocompiler-research:mainfrom
mcbarton:Add-raytracer-notebook-to-deployment

Conversation

@mcbarton
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the notebook itself was added in a separate Pr but it just wasn't deployed is it ? If yes, then this looks correct!

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton
Copy link
Collaborator Author

So the notebook itself was added in a separate Pr but it just wasn't deployed is it ? If yes, then this looks correct!

CppInterOp never references the raytracer notebook currently. Its a change that got missed when xeus-cpp added the notebook. I only noticed after the llvm 21 based deployment got created, and went to test the notebook.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.32%. Comparing base (f0938a8) to head (55c3bfd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files          11       11           
  Lines        3966     3966           
=======================================
  Hits         3146     3146           
  Misses        820      820           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anutosh491
Copy link
Collaborator

So does the notebook work as expected?

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jan 26, 2026

So does the notebook work as expected?

Just tested the notebook locally and get this error message on the last cell

image

@anutosh491
Copy link
Collaborator

Hmm can you try a mamba magic for me. Fetch symengine from emscripten-forge and possibly try out an example (can take inspiration from the demo notebook)

@mcbarton
Copy link
Collaborator Author

So does the notebook work as expected?

Just tested the notebook locally and get this error message on the last cell
image

@anutosh491 I worked out what was causing the error in the ray tracer notebook. It was the fact that jupyterlite-core was still pinned (nothing to do with wasm-exceptions after all). Pushed a commit which unpins jupyterlite-core

The mamba magic still doesn't work though. I get the following error when I try mamba install

image

@anutosh491
Copy link
Collaborator

anutosh491 commented Jan 26, 2026

Okay let's have a look at the mamba magic later. For this Pr let's try to get the raytracer working (if it works, feel free to merge)

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jan 26, 2026

Okay let's have a look at the mamba magic later. For this Pr let's try to get the raytracer working

The raytracer notebook is now working after my latest commit. Merging.

@mcbarton mcbarton merged commit 98cb86e into compiler-research:main Jan 26, 2026
29 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants