Add raytracer notebook to deployment#786
Conversation
anutosh491
left a comment
There was a problem hiding this comment.
So the notebook itself was added in a separate Pr but it just wasn't deployed is it ? If yes, then this looks correct!
CppInterOp never references the raytracer notebook currently. Its a change that got missed when xeus-cpp added the notebook. I only noticed after the llvm 21 based deployment got created, and went to test the notebook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
=======================================
Coverage 79.32% 79.32%
=======================================
Files 11 11
Lines 3966 3966
=======================================
Hits 3146 3146
Misses 820 820 🚀 New features to boost your workflow:
|
|
So does the notebook work as expected? |
|
Hmm can you try a mamba magic for me. Fetch symengine from emscripten-forge and possibly try out an example (can take inspiration from the demo notebook) |
@anutosh491 I worked out what was causing the error in the ray tracer notebook. It was the fact that jupyterlite-core was still pinned (nothing to do with wasm-exceptions after all). Pushed a commit which unpins jupyterlite-core The mamba magic still doesn't work though. I get the following error when I try mamba install
|
|
Okay let's have a look at the mamba magic later. For this Pr let's try to get the raytracer working (if it works, feel free to merge) |
The raytracer notebook is now working after my latest commit. Merging. |



No description provided.