Gh cpython -> LTS-main-1.x#444
Conversation
gonzalocasas
left a comment
There was a problem hiding this comment.
Amazing! Thank you so much! I added some minor comment, but it lgtm
|
@gonzalocasas any idea what's up with this integration test? got it to run locally now but not on remote. seems it hasn't been working for while |
Maybe we just disable these failing tests. @yck011522 tried a ton of things to fix those, and I think the solution in the end was to skip them: 9229af3 |
|
The Ros connection thing occasionally work if you just re run it. Bass on my previous experience, I superstitiously suspect that The py test that is performed in remote can sometimes run multiple tests at the same time, resulting in multiple connections to the same Ros instance which cause it to crash. I also have a feeling that this affects tests to inline codes inside RST files. For proper tests that are inside its independent python file this never seems to be a problem. |
|
ugh I give up. made some fixes to make ironpython tests run but they will still fail until compas-dev/compas#1454 is merged. |
compas_fab.ghpython.components.compas_invocations2.inverse_kinematics_spherical_wrist.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_fab.robots.CollisionMesh.