Skip to content

Gh cpython -> LTS-main-1.x#444

Merged
gonzalocasas merged 36 commits intoLTS-main-1.xfrom
gh-cpython
Apr 15, 2025
Merged

Gh cpython -> LTS-main-1.x#444
gonzalocasas merged 36 commits intoLTS-main-1.xfrom
gh-cpython

Conversation

@chenkasirer
Copy link
Member

@chenkasirer chenkasirer commented Mar 24, 2025

  • Added CPython components.
  • Added some helper functions in compas_fab.ghpython.components.
  • Added the yakerize workflow.
  • Updated dependency to compas_invocations2.
  • Fixed small bug in inverse_kinematics_spherical_wrist.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@chenkasirer chenkasirer changed the title Gh cpython Gh cpython -> LTS-main-1.x Mar 24, 2025
Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you so much! I added some minor comment, but it lgtm

@chenkasirer
Copy link
Member Author

@gonzalocasas any idea what's up with this integration test? got it to run locally now but not on remote. seems it hasn't been working for while

@gonzalocasas
Copy link
Member

@gonzalocasas any idea what's up with this integration test? got it to run locally now but not on remote. seems it hasn't been working for while

Maybe we just disable these failing tests. @yck011522 tried a ton of things to fix those, and I think the solution in the end was to skip them: 9229af3

image

@yck011522
Copy link
Contributor

yck011522 commented Mar 27, 2025

The Ros connection thing occasionally work if you just re run it.

Bass on my previous experience, I superstitiously suspect that The py test that is performed in remote can sometimes run multiple tests at the same time, resulting in multiple connections to the same Ros instance which cause it to crash.

I also have a feeling that this affects tests to inline codes inside RST files. For proper tests that are inside its independent python file this never seems to be a problem.

@chenkasirer
Copy link
Member Author

ugh I give up. made some fixes to make ironpython tests run but they will still fail until compas-dev/compas#1454 is merged.
integration tests I dunno, skipped some as suggested but others still fail. @gonzalocasas @yck011522 are you guys good with merging this PR and we deal with this in a future one?

@gonzalocasas gonzalocasas merged commit 3730ad5 into LTS-main-1.x Apr 15, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants