Skip to content

Conversation

@fstof
Copy link
Contributor

@fstof fstof commented Nov 2, 2025

Scripts wich are clearly AI generated and not further revied by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.

✍️ Description

Added a script for creating LXC container for the application Donetick

🔗 Related PR / Issue

Link: #5214

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

Install works and I was able to test. However, I was not able to test the update part as it fails with some curl error, If someone can point me in a direction to get it sorted, I'd appreciate that

Is it better to rather mark it as "not updatable"?

@tremor021
Copy link
Member

I fixed your script

@MickLesk MickLesk merged commit 8d997ee into community-scripts:main Nov 2, 2025
1 check passed
@fstof
Copy link
Contributor Author

fstof commented Nov 2, 2025

I fixed your script

Wow... and what a fix... :-)

This my first one so just followed the template blindly... looks like your changes make things quite a bit cleaner.
Thank you

May I ask... how long before these new scripts make it to the main repo?

@michelroegl-brunner
Copy link
Member

Usually a few days until they are somewhat tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants