[16.0][MIG] website_sale_affiliate: Migration to 16.0 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pilarvargas-tecnativa, |
Honeyxilia
approved these changes
Jun 20, 2025
Honeyxilia
approved these changes
Jun 20, 2025
| datetime_start = fields.Datetime.from_string(self.date) | ||
| datetime_delta = timedelta(hours=valid_hours) | ||
| expiration = fields.Datetime.to_string(datetime_start + datetime_delta) | ||
| expiration = datetime_start + datetime_delta |
There was a problem hiding this comment.
It is better to use the fields tool and remove the datetime import.
Author
There was a problem hiding this comment.
Hi @pilarvargas-tecnativa Simplification done but I found not field tools to add an integer do self.date. I saw the add function from date_utils but it does not work if valid_hours is greater than 23. Don't hesitate to suggest any other improvement.
Please not that it is not a OCA PR yet, I will push it to OCA later in the day !
|
Could you please improve the title of the PR by following the migration guide? Thanks. |
* [ADD] website_sale_affiliate: Create module * Add sale.affiliate and sale.affiliate.request models * Override WebsiteSale controller shop method to store affiliate id & key kwargs of shop urls in session * Override sale order create method to store affiliate request * Add affiliate and request views, links in Sales/Affiliates * Add affiliate_request_id to sale.order form view * Add request sequence record, make default for new affiliates * Add access rights to sales users/managers * Add tests * Add readme instructions * [IMP] website_sale_affiliate: Make requested changes * Update readme * Add controller override to catch product urls * Remove redundant return None * Replace if statements with try/except when appropriate * Change api decorator on sale.affiliate.find_from_session method from model -> model_cr_context * Add check to avoid unnecessary db search in find_from_session if no affiliate_id * Fix tests * Add new tests * [IMP] website_sale_affiliate: Make requested changes * Un-nest try/except statements for readability * Rename kwargs: ref, key -> aff_ref, aff_key * Improve request search speed for large recordsets * Document similarly-named methods for clarity * Tweak tests as needed * Add additional test * Add roadmap to readme * [REM] website_sale_affiliate: Remove affiliate request IP-matching * [IMP] website_sale_affiliate: Change affiliate request creation * Create affiliate requests regardless of whether a sale occurs * Add basic conversion/sales stats to affiliate model and views * Update tests * Add demo data * Clean up views * Remove line used for debugging * Add field string for clarity * [FIX] website_sale_affiliate: Fix compatibility issues, tests * Fix controller method overrides to avoid conflicts * Match assertAlmostEqual decimal places to amount used in fields * Remove/replace tests with unneeded url_open calls * Rename files, variables for clarity * Clean up demo/test data * [IMP] website_sale_affiliate: Clarify affiliate request name * Add help to name field on affiliate request model
* Handle the case of no web session, which will raise a `RuntimeError('object unbound')` when attempting to access it. This happens during XML record creations, but likely other places such as in the shell
Currently translated at 13.7% (7 of 51 strings) Translation: e-commerce-10.0/e-commerce-10.0-website_sale_affiliate Translate-URL: https://translation.odoo-community.org/projects/e-commerce-10-0/e-commerce-10-0-website_sale_affiliate/it/
Make direct calls to controller instead of using mock. Some tests were removed but the tested functionalities will be tested in their respective test files.
9184Lucky
changed the title
9184Lucky
force-pushed
the
16.0-mig-website_sale_affiliate
branch
from
a6453a6 to
2f76ead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.