[16.0][FIX] contract_payment_auto_job_post_process: Added test_target_state… #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to list of allowed context keys In the following PR, the v16.0 queue_job module was patched to filter context keys, to only allow a select amount of context keys. -> OCA/queue#794 Due to this module's purpose, using both contract_payment_auto (passing test_target_state in tx tests) and contract_queue_job (performing invoice creation in jobs), we might need to create a new module in OCA/contract in order to offer the possibility to other users to pass the test_target_state context value in tests, while using a job to perform invoice creation. However, in the meantime, we added this fix in this module.
Collaborator
|
Hi @fcayre, |
Honeyxilia
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #538 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 584 585 +1
Lines 15701 15708 +7
Branches 1007 1007
=======================================
+ Hits 15415 15422 +7
Misses 157 157
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fcayre
approved these changes
Jan 8, 2026
Collaborator
Author
|
/ocabot rebase |
Collaborator
|
Congratulations, PR rebased to 16.0. |
Collaborator
Author
|
/ocabot merge patch |
Collaborator
|
On my way to merge this fine PR! |
Collaborator
Author
|
For more info: OCA/contract#1376 |
Collaborator
|
Congratulations, your PR was merged at c980f05. Thanks a lot for contributing to commown. ❤️ |
github-grap-bot
deleted the
16.0-fix-contract_payment_auto_job_post_process-test_target_state_in_job_context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to list of allowed context keys
In the following PR, the v16.0 queue_job module was patched to filter context keys, to only allow a select amount of context keys. -> OCA/queue#794
Due to this module's purpose, using both contract_payment_auto (passing test_target_state in tx tests) and contract_queue_job (performing invoice creation in jobs), we might need to create a new module in OCA/contract in order to offer the possibility to other users to pass the test_target_state context value in tests, while using a job to perform invoice creation.
However, in the meantime, we added this fix in this module.