Skip to content

Don't trim non-ASCII whitespace #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Don't trim non-ASCII whitespace #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/inlines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,11 @@ var parseInline = function(block) {
// Parse string content in block into inline children,
// using refmap to resolve references.
var parseInlines = function(block) {
this.subject = block._string_content.trim();
// trim() removes non-ASCII whitespaces, vertical tab, form feed and so on.
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trim#return_value
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#white_space
// Removes only ASCII tab and space.
this.subject = block._string_content.replace(/^[\t \r\n]+|[\t \r\n]+$/g, "")
this.pos = 0;
this.delimiters = null;
this.brackets = null;
Expand Down
28 changes: 28 additions & 0 deletions test/regression.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,3 +518,31 @@ foo <!-- test --> more -->
<p>foo <!-----></p>
<p>foo <!-- test --> more --&gt;</p>
````````````````````````````````

#261
```````````````````````````````` example
Vertical Tab

Form Feed

 NBSP (U+00A0) NBSP 

 Em Space (U+2003) Em Space 


Line Separator (U+2028) Line Separator



Paragraph Separator (U+2029) Paragraph Separator


　全角スペース (U+3000) 全形空白　

ZWNBSP (U+FEFF) ZWNBSP
.
<p> Vertical Tab </p>
<p> Form Feed </p>
<p> NBSP (U+00A0) NBSP </p>
<p> Em Space (U+2003) Em Space </p>
<p>
Line Separator (U+2028) Line Separator
</p>
<p>
Paragraph Separator (U+2029) Paragraph Separator
</p>
<p>　全角スペース (U+3000) 全形空白　</p>
<p>ZWNBSP (U+FEFF) ZWNBSP</p>
````````````````````````````````
Loading