Refactor tests and add churn, complexity metrics

commonalityco · Jul 10, 2024 · d7e1292 · d7e1292
1 parent e1b53e0
commit d7e1292
Show file tree

Hide file tree

Showing 6 changed files with 106 additions and 96 deletions.
diff --git a/packages/data-constraints/src/get-constraint-results.test.ts b/packages/data-constraints/src/get-constraint-results.test.ts
@@ -89,7 +89,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -128,7 +128,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -167,7 +167,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -206,7 +206,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -247,7 +247,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -263,7 +263,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -304,7 +304,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -320,7 +320,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -361,7 +361,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -408,7 +408,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -424,7 +424,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-c',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -465,7 +465,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -524,19 +524,19 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
           {
             source: 'pkg-b',
             target: 'pkg-c',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
           {
             source: 'pkg-c',
             target: 'pkg-d',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -553,19 +553,19 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'development',
+            type: DependencyType.DEVELOPMENT,
             version: '1.0.0',
           },
           {
             source: 'pkg-b',
             target: 'pkg-c',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
           {
             source: 'pkg-c',
             target: 'pkg-d',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -605,7 +605,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -645,7 +645,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -685,7 +685,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-a',
             target: 'pkg-b',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -774,7 +774,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-one',
             target: 'pkg-two',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -790,7 +790,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-one',
             target: 'pkg-three',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -806,7 +806,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-one',
             target: 'pkg-four',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -822,7 +822,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-four',
             target: 'pkg-six',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],
@@ -838,7 +838,7 @@ describe('get-constraint-results', () => {
           {
             source: 'pkg-three',
             target: 'pkg-one',
-            type: 'production',
+            type: DependencyType.PRODUCTION,
             version: '1.0.0',
           },
         ],

diff --git a/packages/data-packages/src/get-package.test.ts b/packages/data-packages/src/get-package.test.ts
@@ -53,6 +53,8 @@ describe('getPackage', () => {
       path: 'packages/pkg-one',
       type: PackageType.NODE,
       version: '1.0.0',
+      churn: 0.3,
+      complexity: 0.3,
     });
   });
 });
diff --git a/packages/data-packages/src/get-packages.test.ts b/packages/data-packages/src/get-packages.test.ts
@@ -21,6 +21,8 @@ describe('getPackages', () => {
         description: 'root description',
         path: '.',
         type: PackageType.NODE,
+        churn: 0.3,
+        complexity: 0.3,
       },
     ]);
   });
@@ -41,13 +43,17 @@ describe('getPackages', () => {
         description: 'pkg-one description',
         path: 'packages/pkg-one',
         type: PackageType.NODE,
+        churn: 0.3,
+        complexity: 0.3,
       },
       {
         name: 'pkg-two',
         version: '1.0.0',
         description: 'pkg-two description',
         path: 'packages/pkg-two',
         type: PackageType.NODE,
+        churn: 0.3,
+        complexity: 0.3,
       },
     ]);
   });

diff --git a/packages/data-tags/test/set-tags.test.ts b/packages/data-tags/test/set-tags.test.ts
@@ -7,8 +7,12 @@ import { fileURLToPath } from 'node:url';
 import { PackageType } from '@commonalityco/utils-core';
 
 describe('setTags', () => {
+  const temporaryDirectoryPath = path.join(
+    process.env['RUNNER_TEMP'] || os.tmpdir(),
+    'set-tags-',
+  );
+
   describe('when setting tags for a package with no configuration file', () => {
-    const temporaryDirectoryPath = process.env['RUNNER_TEMP'] || os.tmpdir();
     const temporaryPath = mkdtempSync(temporaryDirectoryPath);
     const emptyFixturePath = path.resolve(
       path.dirname(fileURLToPath(import.meta.url)),
@@ -50,6 +54,8 @@ describe('setTags', () => {
           path: './packages/pkg-one',
           type: PackageType.NEXT,
           version: '1.0.0',
+          churn: 0.5,
+          complexity: 0.5,
         },
         tags: ['tag-one'],
       });
@@ -61,7 +67,6 @@ describe('setTags', () => {
   });
 
   describe('when setting tags for a package with existing tags', () => {
-    const temporaryDirectoryPath = process.env['RUNNER_TEMP'] || os.tmpdir();
     const temporaryPath = mkdtempSync(temporaryDirectoryPath);
     const fixturePath = path.resolve(
       path.dirname(fileURLToPath(import.meta.url)),

diff --git a/packages/utils-conformance/src/diff.test.ts b/packages/utils-conformance/src/diff.test.ts
@@ -33,8 +33,8 @@ describe('diff', () => {
 
     expect(result).toMatchInlineSnapshot(`
       "  Object {
-          \\"name\\": \\"pkg-a\\",
-      +   \\"name\\": \\"pkg-b\\",
+          "name": "pkg-a",
+      +   "name": "pkg-b",
         }"
     `);
   });