Open
Conversation
Rewrite OmnitecProvider to use OsAccess API instead of Rent&Pass. OsAccess natively supports time-bounded passcodes, booking cancellation, and modification via bookId, resolving all gaps from the Rent&Pass API.
Tests for time range validation (UTC enforcement, ordering), CodeResult immutability and masked repr, and exception hierarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OmnitecProviderusing the OsAccess API (osaccess-backend.osaccess.net/api) for PMS-level lock management:create_code: passcodes with time windows (dateTimeCheckin/dateTimeCheckout)invalidate_code: booking cancellation viaPUT /Reservas/{id}/onlineCancel(idempotent)modify_code: direct modification viabookId, with create+delete fallbacktest_connection: auth verification via headers (instance+apikey)roomdoo-locks-omnitec: auth headers, create/invalidate/modify flows, fallback strategy, error mapping (401/403/404/5xx with retries)roomdoo-locks-base: UTC validation, time range ordering,CodeResultimmutability, exception hierarchy