test(cz_customize): add missing YAML configuration file tests #1516
+80
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian DC <[email protected]>
> commitizen.exceptions.InvalidConfigurationError: Failed to parse not_exist.yaml: while scanning a double-quoted scalar > found unknown escape character 's' Signed-off-by: Adrian DC <[email protected]>
> test_commit_parser[config2] - AssertionError:
> assert '(?P<message>.*)' == '^(?P<change_...<message>.*)?'
> test_changelog_pattern[config2] - AssertionError:
> assert '.*' == '^(feature|bug fix)?(!)?'
> test_change_type_map[config2] - AssertionError:
> assert None == {'bug fix': 'Fix', 'feature': 'Feat'}
Signed-off-by: Adrian DC <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
+ Coverage 97.33% 97.66% +0.32%
==========================================
Files 42 57 +15
Lines 2104 2653 +549
==========================================
+ Hits 2048 2591 +543
- Misses 56 62 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Adrian DC <[email protected]>
Lee-W
reviewed
Jun 9, 2025
Comment on lines
+113
to
+119
| message_template: '{{change_type}}:{% if show_message %} {{message}}{% endif %}' | ||
| example: 'feature: this feature enable customize through config file' | ||
| schema: "<type>: <body>" | ||
| schema_pattern: "(feature|bug fix):(\\s.*)" | ||
| bump_pattern: "^(break|new|fix|hotfix)" | ||
| commit_parser: "^(?P<change_type>feature|bug fix):\\s(?P<message>.*)?" | ||
| changelog_pattern: "^(feature|bug fix)?(!)?" | ||
| schema: '<type>: <body>' | ||
| schema_pattern: '(feature|bug fix):(\\s.*)' | ||
| bump_pattern: '^(break|new|fix|hotfix)' | ||
| commit_parser: '^(?P<change_type>feature|bug fix):\\s(?P<message>.*)?' | ||
| changelog_pattern: '^(feature|bug fix)?(!)?' |
There was a problem hiding this comment.
not sure why we need to change it 🤔
Lee-W
reviewed
Jun 9, 2025
| @@ -125,7 +125,7 @@ commitizen: | |||
| new: MINOR | |||
| fix: PATCH | |||
| hotfix: PATCH | |||
| change_type_order: ["BREAKING CHANGE", "feat", "fix", "refactor", "perf"] | |||
| change_type_order: ['BREAKING CHANGE', 'feat', 'fix', 'refactor', 'perf'] | |||
Lee-W
reviewed
Jun 9, 2025
|
|
||
| commit_mock = mocker.patch("commitizen.git.commit") | ||
| commit_mock.return_value = cmd.Command( | ||
| 'nothing added to commit but untracked files present (use "git add" to track)', |
There was a problem hiding this comment.
we might encounter issue if the language is not set to en_US. probably worth setting it up for this test
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
Lee-W
reviewed
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial rebase of #1207 for tests commits made last summer.