build(.gitignore): ignore pyrightconfig.json and poetry.toml#1483
Closed
gbaian10 wants to merge 30 commits intocommitizen-tools:refactorsfrom
Closed
build(.gitignore): ignore pyrightconfig.json and poetry.toml#1483gbaian10 wants to merge 30 commits intocommitizen-tools:refactorsfrom
pyrightconfig.json and poetry.toml#1483gbaian10 wants to merge 30 commits intocommitizen-tools:refactorsfrom
Conversation
Since the project requires Python >=3.9, argparse only raises SystemExit when non-existent commands are provided, making TypeError handling unnecessary.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1483 +/- ##
============================================
Coverage ? 97.82%
============================================
Files ? 57
Lines ? 2619
Branches ? 0
============================================
Hits ? 2562
Misses ? 57
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
reviewed
Jun 8, 2025
|
|
||
| ### Python Patch ### | ||
| # Poetry local configuration file - https://python-poetry.org/docs/configuration/#local-configuration | ||
| poetry.toml |
Member
There was a problem hiding this comment.
I'm kinda curious what the behavior you decide but we shouldn't add it to commitizen
| .ruff_cache | ||
|
|
||
| # LSP config files | ||
| pyrightconfig.json |
Member
There was a problem hiding this comment.
I would suggest adding it to your ~/.gitignore instead. I don't like to add things to ignore that's not directly related to commitizen (yep ".vscode" is kinda not my taste either)
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
Lee-W
force-pushed
the
refactors
branch
2 times, most recently
from
baee83e to
a9cd957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I referred to the
.gitignoretemplate from this webpage and suggest adding two items to be ignored:pyrightconfig.json– For users who use VS Code, they might have their own preferred configurations forpyright/pylance.poetry.toml– This repository uses Poetry to manage packages. This file can be used to configure some Poetry-related environment variables for the project, such as creating the virtual environment inside the project directory instead of under the .cache folder in the home directory.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context