Skip to content

remove open/writable check from canUseUtf8, add assertWritable #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove open/writable check from canUseUtf8, add assertWritable #270

wants to merge 1 commit into from

Conversation

@akhra
Copy link
Collaborator

@akhra akhra commented Oct 14, 2025

addresses #269

@akhra
Copy link
Collaborator Author

akhra commented Oct 14, 2025

@jeltsch did this miss anything?

@akhra akhra requested a review from mpilgrem October 14, 2025 06:25
@jeltsch
Copy link
Contributor

jeltsch commented Oct 14, 2025

I cannot really judge where the best place for this check would be, because I’m not so familiar with the rio code, but the changes look plausible to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpilgrem mpilgrem Awaiting requested review from mpilgrem

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhra @jeltsch