-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dropin-starter-template.md #212
Conversation
Creates the initial draft for using the dropin starter template.
Yes, they should create a container first
Then a UI component
Update their sandbox environment to render their container that has the UI component ( |
Is this content publicly available anywhere? https://elsie.dev/docs/ I see that it's still behind a permission wall thats based on GitHub users. If not, how would external developers know how to work with the SDK components? |
@jcalcaben, it's not public yet. we plan to integrate the SDK storybook output from the elsie site with the current docs site to create a unified experience. last i heard, we need to do this for the April 8th marketing release window. i assume that also means we should figure out how the content in this PR fits with that. @bdenham is going to look into it when he wraps up the summit lab workbook. |
Co-authored-by: James Calcaben <[email protected]>
Updates instructions to include generating a component, a container, and adding the container to the sandbox env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is good enough as a starting point. We'll probably need additional in depth guides on dropin development best practices.
I think we need to clean up the sandbox index.html file so that there is less to remove or comment out to get things working, but that can be its own PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with acceptance of suggested changes. Nice job, Andy!
Co-authored-by: Bruce Denham <[email protected]>
Co-authored-by: Bruce Denham <[email protected]>
Removes "conclusion" section
@supernova-at Please add supported Node versions as Maintenance (20) and Active (22) |
Incorporates change suggestions
|
||
## How to Use the Adobe Commerce Drop-in Template | ||
|
||
Note: Supported Node versions are: Maintenance (v20) and Active (v22). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: new content added here per #212 (comment).
Incorporates suggested fixes Co-authored-by: Bruce Denham <[email protected]>
Creates the initial draft for using the dropin starter template.