Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L320workbook #211

Open
wants to merge 57 commits into
base: USF-2006
Choose a base branch
from
Open

L320workbook #211

wants to merge 57 commits into from

Conversation

bdenham
Copy link
Collaborator

@bdenham bdenham commented Mar 12, 2025

This PR takes the place of Lab320 to invite last updates and reviews, including Olena T's addition content.

Reviewer Instructions

Review the following four files. The files will be generated into the PDF lab workbook for Summit:

  • src/content/docs/merchants/tutorials/summit-lab-320/index.mdx
  • src/content/docs/merchants/tutorials/summit-lab-320/create-product-page.mdx
  • src/content/docs/merchants/tutorials/summit-lab-320/create-product-campaign.mdx
  • src/content/docs/merchants/tutorials/summit-lab-320/create-experiment.mdx

bdenham and others added 30 commits March 6, 2025 09:13
@bdenham bdenham requested review from tkacheva and jeff-matthews and removed request for tkacheva March 12, 2025 22:11
@bdenham bdenham marked this pull request as ready for review March 12, 2025 22:11
@bdenham bdenham requested a review from tkacheva March 12, 2025 22:11
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like the new nav pattern for developers and merchants.

I just have some minor editorial comments about formatting. The flow makes sense.

The only thing I'm wondering about is: what happens if we deploy this to prod and someone who isn't attending the lab attempts it?

  • Will they be able to do it? If so, for how long before some lab resource is decommissioned?
  • How are you envisioning the transition to evergreen use case docs post-Summit lab?


<Steps>
1. Navigate to folder `products`.
1. Create a folder called `apple-iphone-13`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create a folder called `apple-iphone-13`.
1. Create a folder named `apple-iphone-13`.

### Preview the page

<Steps>
1. Click the instant **Preview** button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that's the paper plane icon based on the lab warm up, but this still made me pause.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no. I'm referring to a different button than the paper plane Action button. So that's a good, valid callout. I need to find a nice solution for inline button images.

<Steps>
1. Insert a new —*Section Break*— directly after the Hero block's `section-metadata` using the **Section Break** tool in the Edit menu.
1. Insert a **`targeted-block fragment`** from `Library > Blocks > Targeted Blocks`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Library > Blocks > Targeted Blocks should be code formatted. We use bolding elsewhere.


<Steps>
1. From the home page preview, select `Account > Login` from the site's navigation menu and enter these credentials:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Account > Login should be code formatted. We use bolding elsewhere.

1. Open the `cart` document in your project root.
1. Insert a new —*Section Break*— directly after the `commerce-cart` **metadata** block using the **Section Break** tool in the Edit menu.
1. Insert a **`targeted-block fragment`** from `Library > Blocks > Targeted Blocks`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Library > Blocks > Targeted Blocks should be code formatted. We use bolding elsewhere.

<Steps>
1. Click the **Action** button (paper plane icon), select **Preview**.
1. Login to the site as a Plan-Connect customer (`Account > Login`) and enter the following credentials:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Account > Login should be code formatted. We use bolding elsewhere.

@bdenham
Copy link
Collaborator Author

bdenham commented Mar 12, 2025

@jeff-matthews, yeah, all great questions. After I generate the PDF for the lab later tonight, I’ll think it through to find a solution for publishing to production tomorrow afternoon. Stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants