-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USF-2007 - UpdateProductsFromCart Docs #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions
@@ -546,6 +548,7 @@ The `UpdateProductsFromCart` object has the following parameters: | |||
['Parameter', 'Type', 'Req?', 'Description'], | |||
['uid', 'string', 'Yes', 'The unique ID of an item in the cart.'], | |||
['quantity', 'number', 'Yes', 'The new quantity of the item.'], | |||
['optionsUIDs', 'string[]', 'No', 'The selected options for the product, such as color or size, using the unique ID for an object.'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['optionsUIDs', 'string[]', 'No', 'The selected options for the product, such as color or size, using the unique ID for an object.'] | |
['optionsUIDs', 'string[]', 'No', 'The selected options for the product using the unique ID for an object.'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe in here, instead of providing examples, we could provide the possible options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danidelcar the possible options meaning example optionsUIDs
numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericeoeur you mentioned examples like color or size, is there a list of possible options like those?, might be worth adding that. If we're talking about a long list, then no. Hope it helps!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can be a pretty long list! Lets keep it as you suggested then. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might look into adding a link to that info, if we have it, but for the moment, we can go ahead with this PR
Co-authored-by: Daniel Del Carmen <[email protected]>
Co-authored-by: Daniel Del Carmen <[email protected]>
Jira Ticket: https://jira.corp.adobe.com/browse/USF-2007
Storefront Cart PR: https://git.corp.adobe.com/Commerce-Storefront/storefront-cart/pull/244
AC