Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USF-2007 - UpdateProductsFromCart Docs #210

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

ericeoeur
Copy link
Contributor

@ericeoeur ericeoeur commented Mar 11, 2025

@jeff-matthews jeff-matthews added the documentation Improvements or additions to documentation label Mar 11, 2025
Copy link
Contributor

@danidelcar danidelcar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@@ -546,6 +548,7 @@ The `UpdateProductsFromCart` object has the following parameters:
['Parameter', 'Type', 'Req?', 'Description'],
['uid', 'string', 'Yes', 'The unique ID of an item in the cart.'],
['quantity', 'number', 'Yes', 'The new quantity of the item.'],
['optionsUIDs', 'string[]', 'No', 'The selected options for the product, such as color or size, using the unique ID for an object.']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
['optionsUIDs', 'string[]', 'No', 'The selected options for the product, such as color or size, using the unique ID for an object.']
['optionsUIDs', 'string[]', 'No', 'The selected options for the product using the unique ID for an object.']

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in here, instead of providing examples, we could provide the possible options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danidelcar the possible options meaning example optionsUIDs numbers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericeoeur you mentioned examples like color or size, is there a list of possible options like those?, might be worth adding that. If we're talking about a long list, then no. Hope it helps!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be a pretty long list! Lets keep it as you suggested then. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might look into adding a link to that info, if we have it, but for the moment, we can go ahead with this PR

@danidelcar danidelcar merged commit d341aab into develop Mar 13, 2025
3 checks passed
@danidelcar danidelcar deleted the USF-2007-Remove-Update-Product branch March 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants