Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim stream to version #294

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

drteeth
Copy link
Contributor

@drteeth drteeth commented Jan 14, 2025

Implement stream trimming:

Delete earlier events in a stream up to a given version

@drteeth drteeth requested review from jwilger and cdegroot January 14, 2025 03:12
@jwilger
Copy link
Contributor

jwilger commented Jan 15, 2025

Changes look fine to me. I'm curious what @drteeth and @cdegroot would think about following a process where PRs for net-new functionality like this should always have an accompanying ADR in the new ADR Repo?

@drteeth drteeth marked this pull request as draft January 16, 2025 15:36
@drteeth
Copy link
Contributor Author

drteeth commented Jan 16, 2025

This misses what to do with event handlers that have not yet seen the events that are about to deleted, and it doesn't take into account what to do with events linked into other streams.

Moving the discussion to ADR seems like a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants