Skip to content

HKG: Add FW for 2024 Kia Forte #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

HKG: Add FW for 2024 Kia Forte #2805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
559f494
Update values.py
shurtadohwnew Sep 25, 2025
e155471
Update fingerprints.py
shurtadohwnew Sep 25, 2025
12ab725
Update hyundaican.py
shurtadohwnew Sep 26, 2025
417d4dd
Update values.py
shurtadohwnew Sep 26, 2025
aa4ed60
Instead of a new 2024 Kia forte Add to exisiting 21-23
shurtadohwnew Sep 27, 2025
166d89b
Order fwdRadar 24 Module
shurtadohwnew Sep 27, 2025
38ef59c
Merge branch 'master' into master
jyoung8607 Oct 10, 2025
375d00a
data collection only ECU
jyoung8607 Oct 10, 2025
79b8551
auto_fingerprint 850678021a7879cc/00000001--deed8039bc
jyoung8607 Oct 10, 2025
ad37362
retry CI
jyoung8607 Oct 10, 2025
0f03193
whitespace fix
jyoung8607 Oct 10, 2025
cf61672
flaky tests really damage my calm
jyoung8607 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions opendbc/car/hyundai/fingerprints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,14 +585,17 @@
b'\xf1\x00BD MDPS C 1.00 1.08 56310/M6300 4BDDC108',
b'\xf1\x00BD MDPS C 1.00 1.08 56310M6300\x00 4BDDC108',
b'\xf1\x00BDm MDPS C A.01 1.01 56310M7800\x00 4BPMC101',
b'\xf1\x00BDm MDPS C A.01 1.03 56300M7800\x00 4BPMC103',
b'\xf1\x00BDm MDPS C A.01 1.03 56310M7800\x00 4BPMC103',
],
(Ecu.fwdCamera, 0x7c4, None): [
b'\xf1\x00BD LKAS AT USA LHD 1.00 1.04 95740-M6000 J33',
b'\xf1\x00BDP LKAS AT USA LHD 1.00 1.05 99211-M6500 744',
b'\xf1\x00BDP LKAS AT USA LHD 1.01 1.06 99211-M6500 745',
],
(Ecu.fwdRadar, 0x7d0, None): [
b'\xf1\x00BDPE_SCC FHCUPC 1.00 1.04 99110-M6500\x00\x00\x00\x00\x00\x00\x00\x00\x00',
b'\xf1\x00BDPE_SCC FHCUPC 1.01 1.04 99110-M6500\x00\x00\x00\x00\x00\x00\x00\x00\x00',
b'\xf1\x00BD__ SCC H-CUP 1.00 1.02 99110-M6000 ',
],
},
Expand Down
2 changes: 1 addition & 1 deletion opendbc/car/hyundai/hyundaican.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def create_lkas11(packer, frame, CP, apply_torque, steer_req,
CAR.HYUNDAI_ELANTRA_HEV_2021, CAR.HYUNDAI_SONATA_HYBRID, CAR.HYUNDAI_KONA_EV, CAR.HYUNDAI_KONA_HEV, CAR.HYUNDAI_KONA_EV_2022,
CAR.HYUNDAI_SANTA_FE_2022, CAR.KIA_K5_2021, CAR.HYUNDAI_IONIQ_HEV_2022, CAR.HYUNDAI_SANTA_FE_HEV_2022,
CAR.HYUNDAI_SANTA_FE_PHEV_2022, CAR.KIA_STINGER_2022, CAR.KIA_K5_HEV_2020, CAR.KIA_CEED,
CAR.HYUNDAI_AZERA_6TH_GEN, CAR.HYUNDAI_AZERA_HEV_6TH_GEN, CAR.HYUNDAI_CUSTIN_1ST_GEN, CAR.HYUNDAI_KONA_2022):
CAR.HYUNDAI_AZERA_6TH_GEN, CAR.HYUNDAI_AZERA_HEV_6TH_GEN, CAR.HYUNDAI_CUSTIN_1ST_GEN, CAR.HYUNDAI_KONA_2022, CAR.KIA_FORTE):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it necessary to add this in order for your car to be usable? This is a substantial change for all other model-years of Kia Forte. Even if it's right for your car, we'd have to see if it breaks older Forte.

@sunnyhaibin this is my least favorite line of code in all of opendbc. Is there no way to auto-detect if we have a more modern instrument cluster?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a while ago but couldn't find any pattern in this message alone. That's not to say it's not possible though

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necesary, this change should be omitted

values["CF_Lkas_LdwsActivemode"] = int(left_lane) + (int(right_lane) << 1)
values["CF_Lkas_LdwsOpt_USM"] = 2

Expand Down
2 changes: 1 addition & 1 deletion opendbc/car/hyundai/values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ class CAR(Platforms):
KIA_FORTE = HyundaiPlatformConfig(
[
HyundaiCarDocs("Kia Forte 2019-21", min_enable_speed=6 * CV.MPH_TO_MS, car_parts=CarParts.common([CarHarness.hyundai_g])),
HyundaiCarDocs("Kia Forte 2022-23", car_parts=CarParts.common([CarHarness.hyundai_e])),
HyundaiCarDocs("Kia Forte 2022-24", car_parts=CarParts.common([CarHarness.hyundai_e])),
],
CarSpecs(mass=2878 * CV.LB_TO_KG, wheelbase=2.8, steerRatio=13.75, tireStiffnessFactor=0.5)
)
Expand Down
Loading