Remove atomicwrites dependency, use stdlib tempfile + os.replace#173
Open
dhruvildarji wants to merge 1 commit intocommaai:masterfrom
Open
Remove atomicwrites dependency, use stdlib tempfile + os.replace#173dhruvildarji wants to merge 1 commit intocommaai:masterfrom
dhruvildarji wants to merge 1 commit intocommaai:masterfrom
Conversation
Replace the deprecated `atomicwrites` library with stdlib `tempfile.NamedTemporaryFile` + `os.replace`/`os.link` for atomic file writes. This removes an unnecessary third-party dependency while preserving the same race-condition safety. Fixes commaai#118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atomicwriteslibrary with stdlibtempfile.NamedTemporaryFile+os.replace/os.linkatomicwritesfrompyproject.tomldependencies andrequirements_examples.txtApproach
As suggested in #118,
atomicwritesis deprecated and the author recommends usingos.replace/os.renameinstead. This PR:NamedTemporaryFile+os.replacefor atomic overwriteNamedTemporaryFile+os.replace(whenoverwrite=True) oros.link(whenoverwrite=False, which raisesFileExistsErrorif the file already exists, matching the previous behavior)Both patterns write to a temp file in the same directory (ensuring same filesystem) before atomically moving into place, which is safe for concurrent downloads.
Test plan
atomicwritesin the codebaseatomicwriteswas introducedFixes #118