Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added downloading and storing publications from the server [#9] #65

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Feb 2, 2025

  • Changed the Android app context to be visible from the shared module.
  • Added streaming and downloading APIs to Android.

Closes #9

Status

READY

Does this PR contain migrations?

YES

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

 * Changed the Android app context to be visible from the shared module.
 * Added streaming and downloading APIs to Android.
@mcpierce mcpierce added the enhancement A pull request containing a new or refactored feature. label Feb 2, 2025
@mcpierce mcpierce added this to the 0.1 milestone Feb 2, 2025
Copy link

sonarqubecloud bot commented Feb 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mcpierce mcpierce merged commit 7fb8c8d into comixed:main Feb 2, 2025
4 of 5 checks passed
@mcpierce mcpierce deleted the feature/issue-9 branch February 2, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A pull request containing a new or refactored feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A comic book file can be downloaded from an OPDS library.
1 participant